NetHack: fix rendering, handle timeouts #294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR itroduces two small changes to the NetHack example
Fix rendering
Not sure if this is the best way to do this, but I wanted to correctly handle rendering.
There is an issue when using
GymV21CompatibilityV0
from shimmy library. Precisely inreset()
they callenv.render()
beforeenv.reset()
which throws an error in NLE.To fix this I've added modified
GymV21CompatibilityV0
wrapper which swaps the order ofenv.reset()
andenv.render()
.Handle timeouts
NLE is compatible with gym==0.21 and it doesn't distinguish between termination and truncation. Normally
GymV21CompatibilityV0
handles this, but it needsinfo["TimeLimit.truncated"]
to do so. I made it work by adding a simple wrapper.