New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix actor critic separate weights PackedSequence #290

Merged

klyuchnikova-ana merged 1 commit into alex-petrenko:master from BartekCupial:fix_ac_separate_weights

Jan 11, 2024

Collaborator

BartekCupial commented Jan 10, 2024

Quite self-explanatory. For some reason ActorCriticSeparateWeights wasn't updated to support PackedSequence.
As I've explained in the comment.

We cannot chunk PackedSequence directly, we first have to to unpack it, chunk, 
then pack chunks again to be able to process then through the cores. 
Finally we have to return concatenated outputs so we repeat the proces, 
but this time using concatenation - unpack, cat and pack.


          fix actor critic separate weights

ddca6a5

klyuchnikova-ana approved these changes

View reviewed changes

klyuchnikova-ana merged commit ed837fb into alex-petrenko:master

8 of 10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet