Skip to content

Commit

Permalink
Remove opencv-python from macOS dependencies in setup.py
Browse files Browse the repository at this point in the history
  • Loading branch information
alex-petrenko committed Jun 20, 2024
1 parent aa3a457 commit e0c8ad8
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 2 deletions.
8 changes: 8 additions & 0 deletions docs/11-release-notes/release-notes.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Recent releases

##### v2.1.3

* Minor compatibility fixes

##### v2.1.2

* Minor compatibility fixes

##### v2.1.1

* Windows support in serial mode (do not require `faster-fifo` on Windows)
Expand Down
11 changes: 9 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import platform
import setuptools
from setuptools import setup

Expand Down Expand Up @@ -35,6 +36,13 @@
"mkdocs-git-authors-plugin",
]

def is_macos():
return platform.system() == 'Darwin'

platform_specific = []
if not is_macos():
platform_specific += ["opencv-python"] # on arm64 the CI build takes forever otherwise

setup(
# Information
name="sample-factory",
Expand Down Expand Up @@ -63,11 +71,10 @@
# "faster-fifo>=1.4.2,<2.0", <-- installed by signal-slot-mp
"signal-slot-mp>=1.0.3,<2.0",
"filelock",
"opencv-python",
"wandb>=0.12.9",
"huggingface-hub>=0.10.0,<1.0",
"pandas",
],
] + platform_specific,
extras_require={
# some tests require Atari and Mujoco so let's make sure dev environment has that
"dev": ["black", "isort>=5.12", "pytest<8.0", "flake8", "pre-commit", "twine"]
Expand Down

0 comments on commit e0c8ad8

Please sign in to comment.