Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoscaling_enabled broken #1

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Fix autoscaling_enabled broken #1

merged 1 commit into from
Jun 7, 2019

Conversation

nauxliu
Copy link

@nauxliu nauxliu commented Jun 4, 2019

autoscaling_enabled is broken because bool will be converted to string value,

maybe is caused by the type constraints:

variable "worker_groups" {
  description = "A list of maps defining worker group configurations to be defined using AWS Launch Configurations. See workers_group_defaults for valid keys."
+  type        = list(map(string))

  default = [
    {
      "name" = "default"
    },
  ]
}

workers.tf Outdated Show resolved Hide resolved
workers_launch_template.tf Outdated Show resolved Hide resolved
workers_launch_template_mixed.tf Outdated Show resolved Hide resolved
@nauxliu
Copy link
Author

nauxliu commented Jun 7, 2019

You are right, Just learned that, Thanks.

Copy link
Owner

@alex-goncharov alex-goncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alex-goncharov alex-goncharov merged commit 22140b0 into alex-goncharov:terraform-0.12 Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants