Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add python3.11 compatibility by using inspect.signature #41

Merged
merged 1 commit into from
Aug 20, 2023
Merged

feat: Add python3.11 compatibility by using inspect.signature #41

merged 1 commit into from
Aug 20, 2023

Conversation

franagustin
Copy link
Contributor

  • Uses inspect.signature for compatibility with Python3.11 (which does not have getargspec function).
  • inspect.signature will be used from Python3.3 onwards, keeping the same behaviour getargspec had.
  • getargspec will still be used for Python < 3.3

@franagustin
Copy link
Contributor Author

@alesdotio

@DmytroLitvinov
Copy link
Collaborator

Hi @alesdotio ,
Thank you for your work on that library. We are using it in our projects :)
We are planning to use Python3.11 and Django4.2 and I would love to help with supporting it.
If you don't have any time on it, I can help you with reviewing MRs and merge them back to master branch. The only needed work would be from your side to release new versions on PyPI so we can get the fresh code which support next Python/Django releases.

@franagustin
Copy link
Contributor Author

Hi @DmytroLitvinov! JFYI, I've been using this branch for Python3.11 and Django4.2 and it's been working so far.
If you try it out and find any issues, please let me know 😁

@DmytroLitvinov
Copy link
Collaborator

Hi @franagustin ,
Great!) I also use master branch from that repo and added monkey patch of that PR into my project. It works, but would be better to have it as PyPI released version.

Thanks for PR, by the way :)

@alesdotio
Copy link
Owner

Hi @alesdotio , Thank you for your work on that library. We are using it in our projects :) We are planning to use Python3.11 and Django4.2 and I would love to help with supporting it. If you don't have any time on it, I can help you with reviewing MRs and merge them back to master branch. The only needed work would be from your side to release new versions on PyPI so we can get the fresh code which support next Python/Django releases.

Hi Dmytro! Thanks for the offer, I made you a collaborator now 😉

@alesdotio alesdotio merged commit 6fb6e2e into alesdotio:master Aug 20, 2023
@alesdotio
Copy link
Owner

A new release is now available https://pypi.org/project/django-admin-shortcuts/2.1.0/, thanks! 😁

@franagustin franagustin deleted the feat/python3.11-compatibility branch August 20, 2023 14:13
@DmytroLitvinov
Copy link
Collaborator

Hi @alesdotio ,
Thanks for the invitation. Received and accepted it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants