Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: Bump ralphc to 3.12.2 #400

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

simerplaha
Copy link
Member

@simerplaha simerplaha commented Feb 26, 2025

Prepare stable release.

Release 0.2.15 from master so that a stable version is available with the latest ralphc.

Question for next PR: Should RC releases with soft-parser enabled remain on 0.2.14-rc[x]?

@simerplaha simerplaha requested a review from tdroxler February 26, 2025 02:50
@tdroxler
Copy link
Member

Release 0.2.15 from master so that a stable version is available with the latest ralphc.

Question for next PR: Should RC releases with soft-parser enabled remain on 0.2.14-rc[x]?

This release should be 0.2.14 no? as we are currently on 0.2.13

We can then continue with the soft parser on 0.2.15-rcx

Or if we want to make a clear separation. We could say that the soft parser will be 0.3.0

so we have 0.3.0-rcx until it's fully ready

and we can continue to increment 0.2.x as much as we want without the soft parser enabled, that would maybe be less confusing and it also show the importance of this soft parser switch

@simerplaha
Copy link
Member Author

simerplaha commented Feb 26, 2025

This release should be 0.2.14 no? as we are currently on 0.2.13
We can then continue with the soft parser on 0.2.15-rcx

I don't think this is standard practice. Releasing 0.2.14 after 0.2.14-rc0 normally means that the changes in 0.2.14-rc0 have been finalised and now stable.

Or if we want to make a clear separation. We could say that the soft parser will be 0.3.0

This wouldn't follow standard versioning convention. Bumping the major 0.3.0 implies breaking changes. For example, the release 0.2.0 had a breaking change because of the move of ralph.json to the directory .ralph-lsp.

@tdroxler
Copy link
Member

I'm fine with any solution, your call.

Base automatically changed from if_else_parser to master February 26, 2025 23:18
@simerplaha simerplaha merged commit 7b57b74 into master Feb 26, 2025
3 checks passed
@simerplaha simerplaha deleted the prepare_release branch February 26, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants