Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeated token check #375

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Repeated token check #375

merged 2 commits into from
Feb 12, 2025

Conversation

simerplaha
Copy link
Member

@simerplaha simerplaha commented Feb 12, 2025 •
edited
Loading

  • Ensure that the input token is not a prefix of another token. For example, if the input token is +, ensure that the token being parsed is neither += nor ++.
  • Removed InfixCallParser.parseOrFail from AssignmentParser (addresses point two in Parser updates #358).

Update: Pending tasks before release

  • Following up on point two in Parser updates #358: The expression parsers executed wherever ExpressionAST is required should be narrowed. I'm working on this now. Important.
  • Improve test coverage.

Towards #104.

@simerplaha simerplaha requested a review from tdroxler February 12, 2025 03:31
Base automatically changed from boundary_checks to master February 12, 2025 07:48
@simerplaha simerplaha merged commit c63c3d7 into master Feb 12, 2025
3 checks passed
@simerplaha simerplaha deleted the repeated_token_check branch February 12, 2025 07:48
@simerplaha simerplaha mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdroxler tdroxler tdroxler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simerplaha @tdroxler