Post beta fixes #352
Merged
Post beta fixes #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nop33
commented
Oct 23, 2023
| options={{ | ||
| host: PUBLIC_POSTHOG_HOST, | ||
| disableGeoip: true, | ||
| enable: settingsLoadedFromStorage && analytics && !!analyticsId, |
There was a problem hiding this comment.
It could be that this line was the issue? :/
There was a problem hiding this comment.
The docs say:
// If set to false, tracking will be disabled until `optIn` is called
https://posthog.com/docs/libraries/react-native#configuration-options
nop33
commented
Oct 24, 2023
| @@ -59,7 +59,7 @@ const AddressCard = ({ style, addressHash, onSettingsPress }: AddressCardProps) | |||
|
|
|||
| const [loading, setLoading] = useState(false) | |||
|
|
|||
| const totalAddressBalance = BigInt(address?.balance ?? 0) + BigInt(address?.lockedBalance ?? 0) | |||
| const totalAddressBalance = BigInt(address?.balance ?? 0) | |||
There was a problem hiding this comment.
I can't believe we did not notice this mistake... User reported it at #353
mvaivre
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mvaivre I am not sure why we have so few analytics recorded on PostHog... My dev client seems to be working fine once I remove the condition that checks if
__DEV__is true.https://stackoverflow.com/questions/34315274/react-native-detect-dev-or-production-env
I hope this PR fixes the issue...