Display tokens and NFTs in horizontal lists #164
Conversation
|
I sooo want to try this with a big wallet so I tries with the infamous "devnet" wallet 🙃 Unfortunately this seems to get the wallet stuck into infinite loading. |
|
Maybe you can try it with a smaller wallet (import the devnet wallet and skip the address discovery) and I can make a new PR for loading optimization. |
|
I didn't get in an infinite loading btw, but it took a while 
|
|
I've created a new PR to improve the loading experience: #165 |
| @@ -33,8 +33,8 @@ interface AddressBoxProps extends PressableProps { | |||
| } | |||
|
|
|||
| const AddressBox = ({ addressHash, isSelected, ...props }: AddressBoxProps) => { | |||
| const selectAddressesAssets = useMemo(makeSelectAddressesAssets, []) | |||
| const assets = useAppSelector((s) => selectAddressesAssets(s, [addressHash])) | |||
| const selectAddressesKnownFungibleTokens = useMemo(makeSelectAddressesKnownFungibleTokens, []) | |||
There was a problem hiding this comment.
Nit: what about separating the useAppSelector calls from the selector factories with a new line?
There was a problem hiding this comment.
I kinda like keeping them close to each other, they are tightly coupled. If you have a strong opinion about this I can change it, but I'd like to keep it as it is.
src/store/assets/assetsActions.ts
Outdated
|
|
||
| dispatch(loadingStarted()) | ||
|
|
||
| let metadata = undefined |
There was a problem hiding this comment.
Nit: this could just be
let metadata
No description provided.