Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total balances do not reflect amounts in transactions list #981

Closed
nop33 opened this issue Nov 20, 2024 · 4 comments · Fixed by #993
Closed

Total balances do not reflect amounts in transactions list #981

nop33 opened this issue Nov 20, 2024 · 4 comments · Fixed by #993
Assignees
Labels
bug Something isn't working 🖥 DW Desktop wallet

Comments

@nop33
Copy link
Member

nop33 commented Nov 20, 2024

@h0ngcha0 reported to me today that he and a friend of his experienced the problem that even though the desktop wallet displays a list of incoming confirmed transactions, the total balance of the wallet in the overview page remains 0.

I've seen a similar issue on Telegram where a user complained that even though their transaction is displayed in the transaction list as well as on our explorer, the balance of their wallet has not updated, even after waiting for 45 minutes. @diomark has experienced this as well.

@nop33 nop33 added bug Something isn't working 🖥 DW Desktop wallet labels Nov 20, 2024
@nop33 nop33 added this to the 👉 DW 2.4.4: Pre-Ledger fixes milestone Nov 20, 2024
nop33 added a commit that referenced this issue Nov 20, 2024
@nop33 nop33 self-assigned this Nov 21, 2024
nop33 added a commit that referenced this issue Nov 21, 2024
@nop33
Copy link
Member Author

nop33 commented Nov 21, 2024

The issue was the skipToken in the ALPH balance query. By simplifying it in the above commit the issue is resolved.

To reproduce it, we sent some ALPH to an address of the wallet that is not the default one.

@nop33
Copy link
Member Author

nop33 commented Dec 11, 2024

Reopening this issue because it still affects some users. Particularly, these have been the new reports:

  1. Case 1: Transferred NFT from an external address to the wallet. Wallet still displays "The wallet doesn't have any NFTs. NFTs of all your addresses will appear here."
  2. Case 2: Exchanged meme token for ALPH. Transaction appeared in wallet, but ALPH amount didn't update.

@nop33 nop33 reopened this Dec 11, 2024
@nop33
Copy link
Member Author

nop33 commented Dec 11, 2024

I discovered the reason why people are reporting that their desktop wallet balances don’t update after transactions are confirmed. It’s because the backend does not respond fast enough to these changes.

  1. When a tx is sent, we poll the GET /transactions/{txHash} endpoint
  2. When the endpoint returns (meaning the tx is confirmed), we immediately call the following endpoints:
    • GET /addresses/{addressHash}/balance
    • GET /addresses/{addressHash}/tokens-balance

I noticed that these endpoints return results that are not up to date.

nop33 added a commit that referenced this issue Dec 11, 2024
nop33 added a commit that referenced this issue Dec 11, 2024
@nop33 nop33 mentioned this issue Dec 11, 2024
nop33 added a commit that referenced this issue Dec 11, 2024
@nop33
Copy link
Member Author

nop33 commented Dec 16, 2024

Fixed in 2.5.0. Closing.

@nop33 nop33 closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🖥 DW Desktop wallet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant