Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Sep 25, 2025

Feature: Support Credits payment method on the notify endpoint.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Integrated credits payment method on the notify endpoint

How to test

Try to send an instance using credits payment method and notify it on the CRN.

@nesitor nesitor requested a review from olethanh September 25, 2025 15:43
@nesitor nesitor self-assigned this Sep 25, 2025
@nesitor nesitor requested a review from 1yam September 25, 2025 15:52
@nesitor nesitor force-pushed the andres-feature-add_credits_to_notify_endpoint branch from e8e3f61 to 08a33ec Compare September 25, 2025 15:56
Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nesitor nesitor requested a review from 1yam September 25, 2025 16:06
Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nesitor nesitor force-pushed the andres-feature-add_credits_to_notify_endpoint branch from cd1fcbb to 47ac652 Compare September 25, 2025 16:10
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 17.85714% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.67%. Comparing base (c79a8cc) to head (d85f1b7).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/payment.py 20.00% 12 Missing ⚠️
src/aleph/vm/orchestrator/views/__init__.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
- Coverage   64.84%   64.67%   -0.18%     
==========================================
  Files          87       87              
  Lines        8095     8121      +26     
  Branches      723      733      +10     
==========================================
+ Hits         5249     5252       +3     
- Misses       2620     2642      +22     
- Partials      226      227       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nesitor nesitor merged commit 7b842b2 into main Sep 25, 2025
34 of 37 checks passed
@nesitor nesitor deleted the andres-feature-add_credits_to_notify_endpoint branch September 25, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants