Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Aug 8, 2025

Feature: Implement credits payment method monitoring, same behaviour as PAYG but with credits.

Related ClickUp, GitHub or Jira tickets : ALEPH-615

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Added credit payment method on balance monitoring task. Also added needed methods to query the API for credit balance based on address.

How to test

Create an intance using credits payment method and remove the credits, the instance should be stopped.

@nesitor nesitor requested a review from olethanh August 8, 2025 08:56
@nesitor nesitor self-assigned this Aug 8, 2025
@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 34.54545% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.42%. Comparing base (79a32c4) to head (eaf4bbc).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/tasks.py 21.73% 16 Missing and 2 partials ⚠️
src/aleph/vm/orchestrator/payment.py 20.00% 16 Missing ⚠️
src/aleph/vm/orchestrator/views/__init__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
- Coverage   64.55%   64.42%   -0.14%     
==========================================
  Files          87       87              
  Lines        8053     8068      +15     
  Branches      723      728       +5     
==========================================
- Hits         5199     5198       -1     
- Misses       2627     2642      +15     
- Partials      227      228       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@olethanh olethanh merged commit 60a4b41 into main Sep 9, 2025
34 of 37 checks passed
@odesenfans odesenfans deleted the andres-feature-implement_credit_payments branch October 8, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants