Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Aug 6, 2025

Related ClickUp, GitHub or Jira tickets : ALEPH-572

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Handle 2 new message status REMOVING and REMOVED for the payments check

How to test

Create an instance on a CRN and then remove the funds to get the message status on REMOVING and then on REMOVED. On REMOVING status should maintain the VM working and when the status pass to REMOVED should stop it.

@nesitor nesitor requested a review from olethanh August 6, 2025 10:09
@nesitor nesitor self-assigned this Aug 6, 2025
@nesitor nesitor force-pushed the andres-feature-handle_2_new_message_status branch 3 times, most recently from 801d510 to e2b07b8 Compare August 12, 2025 16:00
@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.84%. Comparing base (79a32c4) to head (6bac3ad).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
+ Coverage   64.55%   64.84%   +0.28%     
==========================================
  Files          87       87              
  Lines        8053     8095      +42     
  Branches      723      723              
==========================================
+ Hits         5199     5249      +50     
+ Misses       2627     2620       -7     
+ Partials      227      226       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@olethanh olethanh force-pushed the andres-feature-handle_2_new_message_status branch from e2b07b8 to 6bac3ad Compare September 3, 2025 08:49
@olethanh olethanh merged commit c79a8cc into main Sep 3, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants