-
Notifications
You must be signed in to change notification settings - Fork 18
Aleph 565 ipv4 domain support #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
==========================================
- Coverage 65.01% 63.90% -1.12%
==========================================
Files 85 86 +1
Lines 7729 7931 +202
Branches 670 706 +36
==========================================
+ Hits 5025 5068 +43
- Misses 2493 2651 +158
- Partials 211 212 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
735136f
to
7cc688b
Compare
WIP imported from devops POC
Might need to move it to Recomands instead
4a81d68
to
8d2a0b3
Compare
6de877c
to
b68adf5
Compare
b68adf5
to
ceb85bc
Compare
This prevent slow startup that may occur from the https://api.dns.public.aleph.sh/instances/list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall except the 2 comments I added, but I think that we should include also tests for the new class added checking that creates the mapping files well.
Add domain support via HaProxy
Related ClickUp, GitHub or Jira tickets : ALEPH-565
This PR doesn't handle redirect to the CRN itself at the moment. You need to change the Caddy config to use another port 4443FIXEDSelf proofreading checklist
packaging/Makefile
How to test
Setup To test:
On crn
/etc/haproxy/haproxy-aleph.cfg
to/etc/haproxy/haproxy.cfg
to activate it's configsudo systemctl restart haproxy
Deploy an instance
Inside instance install nginx .
Choose a domain name. e.g. echo.agot.be
For https Generate a self signed certificate and config nginx to use it.
If you didn't update your dns, force the domain name by update your /etc/hosts
To test https via curl:
curl -k -v https://echo.agot.be:443
-k
is to allow the self signed certificateTo test http
curl -v http://echo.agot.be:443