-
Notifications
You must be signed in to change notification settings - Fork 18
ALEPH-551 Implement ipv4 port forwarding #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+581
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
- Coverage 65.49% 64.63% -0.86%
==========================================
Files 80 84 +4
Lines 7330 7576 +246
Branches 614 651 +37
==========================================
+ Hits 4801 4897 +96
- Misses 2329 2471 +142
- Partials 200 208 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0343c46
to
0b7fc79
Compare
nesitor
reviewed
Jun 3, 2025
add host ipv4 to v2 endpoint
c8163b0
to
4e7efa0
Compare
nesitor
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/v2/executions/list
endpoint (since we didn't released it yet), as well as the ipv4 address/control/ITEM_HASH/update
endpoint to tell the CRN to reload the configRelated ClickUp, GitHub or Jira tickets : ALEPH-551
Self proofreading checklist
packaging/Makefile
Changes
Notes
At the moment I hard coded a port forwarding of 22/TCC for all instance if there is no aggregate for the user , this is to help testing but will need to be removed before going in production.