Skip to content

Conversation

olethanh
Copy link
Collaborator

Upgrade diagnostic VM to use an ethereum url that don't return 307

https://ethereum.org changed to now return 307
which make the internet check fail and impact node owner score

Internet check : Accept code other than 200 as proper result

The diagnostic VM use raise_for_error to see if it accept the response
this code check if status_code < 400

https://ethereum.org changed to now return 307
which make the internet check fail and impact node owner score
@olethanh olethanh force-pushed the ol-crn-internet-check-fail branch from ae62dc5 to 8a04ba7 Compare April 16, 2025 11:35
The diagnostic VM use raise_for_error to see if it accept the response
this code check if status_code < 400
@olethanh olethanh force-pushed the ol-crn-internet-check-fail branch from 8a04ba7 to 3567e31 Compare April 16, 2025 12:30
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.57%. Comparing base (28582cf) to head (3567e31).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
+ Coverage   64.53%   64.57%   +0.03%     
==========================================
  Files          78       78              
  Lines        7092     7093       +1     
  Branches      598      598              
==========================================
+ Hits         4577     4580       +3     
+ Misses       2315     2313       -2     
  Partials      200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@olethanh olethanh merged commit 675943a into main Apr 16, 2025
22 checks passed
@nesitor nesitor deleted the ol-crn-internet-check-fail branch April 16, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants