enh: allow user to reboot from inside the VM #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: ALEPH-472 Important note: Previously --no-reboot was used so if the BIOS failed to boot the VM because of for example an invalid disk image provided by the user then the QEMU process and the controller would halt. The new behaviour is that the VM will reboot indefinetly. But it should be catched by the wait for init procedure that will test by ping. This new modification was necessary because the GPU VM need a reboot for their setup. And generaly user would be confused when rebooted VM would not restart. The --no-reboot flag was kept for ConfidentialVM as confidential VM do not support reboot anyway
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
=======================================
Coverage 64.54% 64.54%
=======================================
Files 78 78
Lines 7087 7087
Branches 597 597
=======================================
Hits 4574 4574
Misses 2312 2312
Partials 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nesitor
approved these changes
Apr 8, 2025
nesitor
pushed a commit
that referenced
this pull request
Apr 8, 2025
JIRA: ALEPH-472 Important note: Previously --no-reboot was used so if the BIOS failed to boot the VM because of for example an invalid disk image provided by the user then the QEMU process and the controller would halt. The new behaviour is that the VM will reboot indefinetly. But it should be catched by the wait for init procedure that will test by ping. This new modification was necessary because the GPU VM need a reboot for their setup. And generaly user would be confused when rebooted VM would not restart. The --no-reboot flag was kept for ConfidentialVM as confidential VM do not support reboot anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important note: Previously --no-reboot was used so if the BIOS failed to boot the VM because of for example an invalid disk image provided by the user then the QEMU process and the controller would halt. The new behaviour is that the VM will reboot indefinetly. But it should be catched by the wait for init procedure that will test by ping.
This new modification was necessary because the GPU VM need a reboot for their setup. And generaly user would be confused when rebooted VM would not restart.
The --no-reboot flag was kept for ConfidentialVM as confidential VM do not support reboot anyway
Explain what problem this PR is resolving
Related ClickUp, GitHub or Jira tickets : JIRA: ALEPH-472
Self proofreading checklist
packaging/Makefile