Skip to content

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Mar 24, 2025

When aleph-vm-supervisor restarts, it properly loads existing VM interfaces but doesn't re-add their IPv6 ranges to the ndppd proxy configuration. This change explicitly re-adds ndp_proxy rules for existing interfaces during VM recovery.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Added lines to load existing interfaces to ndppd software for the supervisor restart.

How to test

Update a CRN with last version and ensure it loads all ndppd proxy lines of all interfaces.

Notes

🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]

@nesitor nesitor requested a review from olethanh March 24, 2025 12:43
@nesitor nesitor self-assigned this Mar 24, 2025
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.75%. Comparing base (9f6351e) to head (35320c9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/network/ndp_proxy.py 33.33% 4 Missing ⚠️
src/aleph/vm/pool.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
- Coverage   64.80%   64.75%   -0.06%     
==========================================
  Files          78       78              
  Lines        7058     7064       +6     
  Branches      587      590       +3     
==========================================
  Hits         4574     4574              
- Misses       2283     2289       +6     
  Partials      201      201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nesitor nesitor force-pushed the fix-ndppd-proxy-restart branch 2 times, most recently from f2351b8 to 876bcbb Compare March 31, 2025 10:06
nesitor and others added 2 commits March 31, 2025 13:00
When aleph-vm-supervisor restarts, it properly loads existing VM interfaces but
doesn't re-add their IPv6 ranges to the ndppd proxy configuration. This change
explicitly re-adds ndp_proxy rules for existing interfaces during VM recovery.

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
@olethanh olethanh force-pushed the fix-ndppd-proxy-restart branch from 876bcbb to 35320c9 Compare March 31, 2025 11:00
@olethanh olethanh merged commit db49c0e into main Mar 31, 2025
32 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants