Skip to content

Conversation

olethanh
Copy link
Collaborator

Needed for some crns

Needed for some crn
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.34%. Comparing base (6055ad6) to head (a242823).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/network/hostnetwork.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #761   +/-   ##
=======================================
  Coverage   63.34%   63.34%           
=======================================
  Files          77       77           
  Lines        6848     6848           
  Branches      568      568           
=======================================
  Hits         4338     4338           
  Misses       2329     2329           
  Partials      181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@olethanh olethanh requested a review from nesitor February 25, 2025 15:44
@hoh
Copy link
Member

hoh commented Feb 27, 2025

We need to check that this actually works with instances.

@olethanh
Copy link
Collaborator Author

We need to check that this actually works with instances.

We tested this on CRN 1

@nesitor nesitor requested a review from hoh March 18, 2025 14:57
@nesitor nesitor merged commit 73013a2 into main Mar 18, 2025
21 of 22 checks passed
@nesitor nesitor deleted the ol-accept-56-subnet branch March 18, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants