Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Feb 10, 2025

Implemented a settings aggregate query to check the compatible GPUs that we support and also other general settings.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Feature: Added options to get GPU compatibilities from a settings aggregate.

How to test

Go to the /about/usage/system endpoint on a CRN with at least 1 GPU and check if the compatible field appears and also the model one.

@nesitor nesitor self-assigned this Feb 10, 2025
@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 82.62712% with 41 lines in your changes missing coverage. Please review.

Project coverage is 63.35%. Comparing base (7c9392c) to head (18b2f74).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/utils.py 69.81% 11 Missing and 5 partials ⚠️
src/aleph/vm/orchestrator/views/__init__.py 16.66% 15 Missing ⚠️
src/aleph/vm/orchestrator/tasks.py 76.92% 5 Missing and 1 partial ⚠️
src/aleph/vm/resources.py 90.00% 2 Missing ⚠️
src/aleph/vm/pool.py 50.00% 1 Missing ⚠️
tests/supervisor/test_checkpayment.py 99.13% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
+ Coverage   62.16%   63.35%   +1.19%     
==========================================
  Files          75       77       +2     
  Lines        6618     6839     +221     
  Branches      554      566      +12     
==========================================
+ Hits         4114     4333     +219     
+ Misses       2340     2327      -13     
- Partials      164      179      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olethanh
Copy link
Collaborator

The More information is strangely aligned with the gpu list

image

@nesitor nesitor requested a review from olethanh February 12, 2025 13:41
@nesitor nesitor marked this pull request as ready for review February 12, 2025 13:41
@nesitor nesitor force-pushed the andres-feature-implement_gpu_compatibility branch 2 times, most recently from 49e2148 to 8681268 Compare February 12, 2025 14:55
@nesitor
Copy link
Member Author

nesitor commented Feb 12, 2025

The More information is strangely aligned with the gpu list

image

I have already fixed the CSS for Chrome and Firefox and now it shows well.

gpu screenshot

@nesitor nesitor force-pushed the andres-feature-implement_gpu_compatibility branch from 8681268 to 891a437 Compare February 13, 2025 09:43
nesitor and others added 7 commits February 17, 2025 16:00
…tivity check to start notifying the users about the next requirement.
* Implement community payment check WIP

* isort

* Check community flow at allocation

* Community flow  : fix after testing

* mod Use singleton for the Setting Aggregate

* fix test

* Implement community wallet start time
@nesitor nesitor force-pushed the andres-feature-implement_gpu_compatibility branch from 10ce55f to 18b2f74 Compare February 17, 2025 15:00
@nesitor nesitor merged commit 01ff0c1 into main Feb 17, 2025
22 checks passed
@nesitor nesitor deleted the andres-feature-implement_gpu_compatibility branch February 17, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants