Skip to content

Conversation

@olethanh
Copy link
Collaborator

Temporary disable tearing down the network when stopping supervisor Fix issue of persistent instances running inside systemd controller losing their ipv4 Nat access upon supervisor restart or upgrade.

Github issue aleph-im/support#9

this is a temporary hotfix till we have a better solution for handling the network

Temporary disable tearing down the network when stopping supervisor
Fix issue of persistent instances running inside systemd controller losing their ipv4 Nat access
upon supervisor restart or upgrade.

Github issue aleph-im/support#9
@olethanh olethanh force-pushed the ol-fix-instance-nat-issues branch from e09dbf8 to 3b2e938 Compare January 23, 2025 11:33
@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.89%. Comparing base (76c6897) to head (3b2e938).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/pool.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage   62.89%   62.89%           
=======================================
  Files          71       71           
  Lines        6352     6352           
  Branches      519      519           
=======================================
  Hits         3995     3995           
  Misses       2197     2197           
  Partials      160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor merged commit 98b8fc8 into main Jan 23, 2025
18 of 22 checks passed
@nesitor nesitor deleted the ol-fix-instance-nat-issues branch January 23, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants