Fix: Runtime emitted wrong reboot signal #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runtime init `init1.py` emitted the signal `0x4321fedc` to the Linux kernel when shutting down. The correct procedure [according to the Firecracker docs] (https://github.com/firecracker-microvm/firecracker/blob/dfb45dc4213bcb1c9704435457e233d3a210dce2/docs/getting-started.md?plain=1#L298) is to issue a `reboot`. The syscall number for a reboot on Linux is `0x1234567`. Tested using Firecracker independently of `aleph-vm`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
==========================================
+ Coverage 62.89% 62.92% +0.03%
==========================================
Files 71 71
Lines 6352 6352
Branches 519 519
==========================================
+ Hits 3995 3997 +2
+ Misses 2197 2195 -2
Partials 160 160 ☔ View full report in Codecov by Sentry. |
olethanh
approved these changes
Jan 21, 2025
nesitor
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime init
init1.pyemitted the signal0x4321fedcto the Linux kernel when shutting down.
The correct procedure [according to the Firecracker docs]
(https://github.com/firecracker-microvm/firecracker/blob/dfb45dc4213bcb1c9704435457e233d3a210dce2/docs/getting-started.md?plain=1#L298) is to issue a
reboot.The syscall number for a reboot on Linux is
0x1234567.Tested using Firecracker independently of
aleph-vm.