Skip to content

Problem: IGNORE_TRACEBACK_FROM_DIAGNOSTICS broken #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Problem: IGNORE_TRACEBACK_FROM_DIAGNOSTICS broken #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/aleph/vm/orchestrator/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,11 @@

# The Diagnostics VM checks for the proper handling of exceptions.
# This fills the logs with noisy stack traces, so we ignore this specific error.
ignored_error = 'raise CustomError("Whoops")'
ignored_errors = ['raise CustomError("Whoops")', "main.CustomError: Whoops"]

Check warning on line 153 in src/aleph/vm/orchestrator/run.py

View check run for this annotation

Codecov / codecov/patch

src/aleph/vm/orchestrator/run.py#L153 

Added line #L153 was not covered by tests

if settings.IGNORE_TRACEBACK_FROM_DIAGNOSTICS and ignored_error in result["traceback"]:
if settings.IGNORE_TRACEBACK_FROM_DIAGNOSTICS and any(
ignored_error in result["traceback"] for ignored_error in ignored_errors
):
logger.debug('Ignored traceback from CustomError("Whoops")')
else:
logger.warning(result["traceback"])
Expand Down