Skip to content

Conversation

@olethanh
Copy link
Collaborator

@olethanh olethanh commented Oct 8, 2024

Fix the disk creation script to add a more clean message when any step fail.

Related ClickUp, GitHub or Jira tickets : ALEPH-211

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • [N/a] An LLM was used to review the new code and look for simplifications.
  • [N/a] New classes and functions contain docstrings explaining what they provide.
  • [N/a] All new code is covered by relevant tests.
  • [N/a] Documentation has been updated regarding these changes.

Changes

How to test

Follow the step described there https://docs.aleph.im/computing/confidential/encrypted-disk/

Print screen / video

Upload here screenshots or videos showing the changes if relevant.

Notes

@codecov
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.45%. Comparing base (90bae31) to head (b8180ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #709   +/-   ##
=======================================
  Coverage   62.45%   62.45%           
=======================================
  Files          69       69           
  Lines        6139     6139           
  Branches      645      645           
=======================================
  Hits         3834     3834           
  Misses       2153     2153           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor self-requested a review October 9, 2024 10:41
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nesitor nesitor merged commit 49d91d2 into main Oct 9, 2024
22 checks passed
@nesitor nesitor deleted the ol-aleph-211-coco-disk-creation-script-abort-msg branch October 9, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants