Problem: error org.freedesktop.systemd1.NoSuchUnit: Unit aleph-vm-con… #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…troller@... Jira issue: ALEPH-113 This happened because we tried to check if the service was running before checking if it was enabled. It resulted in no proper error but was creating an error message in the logs Solution: Check if service is enabled before checking if it is active How to test: Launch instances. Restart the aleph-vm process, stop them. That error message should not display
hoh
approved these changes
Sep 20, 2024
|
Would it make sense to invest time adding tests on this ? |
|
For this bug in particular no, it was just a message with no effect visible for the user. For the whole systemd subsystem absolutely yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: error org.freedesktop.systemd1.NoSuchUnit: Unit aleph-vm-controller@...
Jira issue: ALEPH-113
This happened because we tried to check if the service was running before checking if it was enabled. It resulted in no proper error but was creating an error message in the logs
Solution: Check if service is enabled before checking if it is active
How to test:
Launch instances. Restart the aleph-vm process, stop them. That error message should not display