Skip to content

Problem: Test failing not clearly #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Problem: Test failing not clearly #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/supervisor/test_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ async def test_create_execution(mocker):
mocker.patch("aleph.vm.controllers.firecracker.executable.settings", new=mock_settings)
mocker.patch("aleph.vm.controllers.firecracker.program.settings", new=mock_settings)

if not mock_settings.FAKE_DATA_RUNTIME.exists():
pytest.xfail("Test Runtime not setup. run `cd runtimes/aleph-debian-12-python && sudo ./create_disk_image.sh`")

mock_settings.FAKE_DATA_PROGRAM = mock_settings.BENCHMARK_FAKE_DATA_PROGRAM
mock_settings.ALLOW_VM_NETWORKING = False
mock_settings.USE_JAILER = False
Expand Down
2 changes: 2 additions & 0 deletions tests/supervisor/test_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ async def test_create_instance():
# Ensure that the settings are correct and required files present.
settings.setup()
settings.check()
if not settings.FAKE_DATA_RUNTIME.exists():
pytest.xfail("Test Runtime not setup. run `cd runtimes/aleph-debian-12-python && sudo ./create_disk_image.sh`")

# The database is required for the metrics and is currently not optional.
engine = metrics.setup_engine()
Expand Down
4 changes: 4 additions & 0 deletions tests/supervisor/test_qemu_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ async def test_create_qemu_instance():
settings.ENABLE_CONFIDENTIAL_COMPUTING = False
settings.ALLOW_VM_NETWORKING = False
settings.USE_JAILER = False
if not settings.FAKE_INSTANCE_BASE.exists():
pytest.xfail("Test Runtime not setup. run `cd runtimes/instance-rootfs && sudo ./create-debian-12-disk.sh`")

logging.basicConfig(level=logging.DEBUG)

Expand Down Expand Up @@ -117,6 +119,8 @@ async def test_create_qemu_instance_online():
# Ensure that the settings are correct and required files present.
settings.setup()
settings.check()
if not settings.FAKE_INSTANCE_BASE.exists():
pytest.xfail("Test Runtime not setup. run `cd runtimes/instance-rootfs && sudo ./create-debian-12-disk.sh`")

# The database is required for the metrics and is currently not optional.
engine = metrics.setup_engine()
Expand Down