Skip to content

Conversation

@Psycojoker
Copy link
Contributor

Sometime in test-using-pytest CI workflow the previous job failed, for example
here,
and this line with if: always() won't be able to run because hatch is
installed in the previous step but this step might get skipped.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • All new code is covered by relevant tests.

Changes

Always install hatch in this always step of the job.

How to test

Make a PR that will fail this job, for example by not respecting black or use
act to test that locally.

@Psycojoker
Copy link
Contributor Author

@hoh this is related to your #689 PR

@Psycojoker Psycojoker requested a review from hoh September 3, 2024 18:56
@codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.69%. Comparing base (02affa3) to head (3ac7244).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage   62.69%   62.69%           
=======================================
  Files          69       69           
  Lines        6069     6069           
  Branches      642      642           
=======================================
  Hits         3805     3805           
  Misses       2113     2113           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoh hoh merged commit 1c888e2 into main Sep 3, 2024
@Psycojoker Psycojoker deleted the lp-fix-ci-hatch-missing branch September 5, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants