Problem: FirecrackerVM not working if /var/lib and /var/cache on two … #682
Conversation
…separate partion The prepare step for jailer was failing because it couldn't create a link to rootfs file when the CACHE and EXECUTION were not on the same partition This was due do trying to make a hardlink instead of as soft symlink (contrary to what the docstring indicated) Solution: Make a symlink
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
==========================================
- Coverage 61.43% 61.31% -0.12%
==========================================
Files 68 68
Lines 5985 5990 +5
Branches 632 634 +2
==========================================
- Hits 3677 3673 -4
- Misses 2155 2163 +8
- Partials 153 154 +1 ☔ View full report in Codecov by Sentry. |
|
What would happen if the cache is cleared while a VM is working and using a file stored there then ? |
|
After @nesitor feedback and more testing I have found a workaround: Do a copy if we can't do a link. Tested and it works properly |
While the VM is working the file is open, and as long as a program has a fd to a file Linux won't actually delete it from the disk so it isn't a problem. But anyway we don't use a symlink anymore |
Co-authored-by: nesitor <[email protected]>
…arate partions Jira Ticket ALEPH-238 Similar issue to #682 That was merged inside #686 We have fixed a variation of this alread but this one triggered for additional volumes only Explanation: The prepare step for jailer is failing because it attempt create a hardlink to a file between the CACHE and EXECUTION dir which is not allowed between separate partition Solution: Make a hardlink Similiarly to the previous resolution, we cannot make a symlink as it is not accessible inside the jailer enclave
#711) FirecrackerVM drive not working if /var/lib and /var/cache on two separate partions Jira Ticket ALEPH-238 Similar issue to #682 That was merged inside #686 We have fixed a variation of this alread but this one triggered for additional volumes only Explanation: The prepare step for jailer is failing because it attempt create a hardlink to a file between the CACHE and EXECUTION dir which is not allowed between separate partition Solution: Make a hardlink Similiarly to the previous resolution, we cannot make a symlink as it is not accessible inside the jailer enclave
…separate partion
The prepare step for jailer was failing because it couldn't create a link to rootfs file when the CACHE and EXECUTION were not on the same partition
This was due do trying to make a hardlink instead of as soft symlink (contrary to what the docstring indicated)
Solution: Make a symlink