Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Aug 21, 2024

Problem: If a user allocates a VM and later forgets the VM, the payment task fails because cannot get the price for that execution.

Solution: Check the message status before checking the price and remove the execution if it is forgotten or on a different status than processed.

…nt task fails because cannot get the price for that execution.

Solution: Check the message status before checking the price and remove the execution if it is forgotten or on a different status than `processed`.
@nesitor nesitor requested review from hoh and olethanh August 21, 2024 16:33
@nesitor nesitor self-assigned this Aug 21, 2024
@codecov
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.28%. Comparing base (2f68012) to head (3428137).
Report is 5 commits behind head on main.

Files Patch % Lines
src/aleph/vm/orchestrator/messages.py 40.00% 6 Missing ⚠️
src/aleph/vm/orchestrator/tasks.py 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
- Coverage   61.44%   61.28%   -0.16%     
==========================================
  Files          68       68              
  Lines        5994     5998       +4     
  Branches      635      635              
==========================================
- Hits         3683     3676       -7     
- Misses       2156     2168      +12     
+ Partials      155      154       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor requested a review from olethanh August 22, 2024 12:18
@olethanh olethanh merged commit 6af63ce into main Aug 23, 2024
@nesitor nesitor deleted the andres-fix-cheack-execution_message_status branch August 23, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants