Mitigate concurrency issues #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…case the id was reused Solution: Base the socket name on the vm_hash
…(and thus network interface) Issue happened with systemd run controller since we could have an id allocated but the controller process not started or running at that moment
hoh
approved these changes
Aug 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
=======================================
Coverage 61.46% 61.46%
=======================================
Files 68 68
Lines 5986 5989 +3
Branches 633 633
=======================================
+ Hits 3679 3681 +2
- Misses 2152 2153 +1
Partials 155 155 ☔ View full report in Codecov by Sentry. |
olethanh
force-pushed
the
ol-mitigate-concurrency-issues
branch
from
ca0dbd4 to
16d729b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch mitigate some of the concurrency issue found during the confidential beta test that prevented some instances from being run or getting in weird state.