Skip to content

Conversation

@olethanh
Copy link
Collaborator

As discussed, providing these informations on each PR should improve review and code quality

@codecov
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.46%. Comparing base (902cf85) to head (f065a3d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files          68       68           
  Lines        5986     5986           
  Branches      633      633           
=======================================
  Hits         3679     3679           
  Misses       2152     2152           
  Partials      155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoh
Copy link
Member

hoh commented Aug 19, 2024

What about reusing the template from https://github.com/aleph-im/aleph-client/pull/244/files instead of the generic one ?

@olethanh
Copy link
Collaborator Author

It's not generic, I Just opened all the Pr at the same time. Will update this one.

@Psycojoker
Copy link
Contributor

Is there any reason not to merge this one?

@hoh
Copy link
Member

hoh commented Aug 28, 2024

I restarted the test that failed.

@hoh hoh merged commit b74d05f into main Aug 28, 2024
@hoh hoh deleted the ol-pr-template branch August 28, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants