Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Jul 29, 2024

Problem: If a user wants to launch a Qemu instance inside a CRN, by default the support is disabled.

Solution: Enable the support by default and disable snapshots because aren't used.

…efault the support is disabled.

Solution: Enable the support by default and disable snapshots because aren't used.
@nesitor nesitor requested review from 1yam, olethanh and philogicae July 29, 2024 10:20
@nesitor nesitor self-assigned this Jul 29, 2024
@codecov
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.51%. Comparing base (15e70e7) to head (8510011).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #662   +/-   ##
=======================================
  Coverage   61.51%   61.51%           
=======================================
  Files          68       68           
  Lines        5986     5986           
  Branches      633      633           
=======================================
  Hits         3682     3682           
+ Misses       2149     2148    -1     
- Partials      155      156    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@philogicae philogicae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nesitor nesitor merged commit e2fcccd into main Jul 29, 2024
@nesitor nesitor deleted the andres-feature-enable_qemu_by_default branch July 29, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants