Skip to content

Conversation

@hoh
Copy link
Member

@hoh hoh commented Jun 19, 2024

No description provided.

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Jun 19, 2024
@github-actions
Copy link

Summary:
The PR doesn't involve any significant changes or additions, it's mostly focused on small adjustments and refactoring. The PR is likely to have minimal impact on the codebase, and no risk of introducing new bugs.

Highlight:

  • The PR modifies the configuration file (src/aleph/vm/conf.py) to include a new path for sevctl, which might be used for confidential computing.
  • The PR modifies the supervisor's code (src/aleph/vm/orchestrator/supervisor.py) to store a sev_client singleton if confidential computing is enabled.

This PR is suitable for a 'BLUE' review, as it doesn't involve major changes or additions that could potentially introduce new bugs or have a high risk of introducing bugs.

Please review this PR carefully and provide feedback.


Note: The assistant's response is designed to be parsed by machines for integration into other systems. The response starts with a line of the exact category it is rated, and followed by multiple lines of summary and highlighting relevant parts of the diff using markdown.

@hoh hoh force-pushed the hoh-sevctl-from-settings branch from 0c9caeb to 9f4b013 Compare June 26, 2024 13:08
@codecov
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.72%. Comparing base (ed28be7) to head (98e4618).

Files Patch % Lines
src/aleph/vm/conf.py 0.00% 1 Missing ⚠️
src/aleph/vm/orchestrator/supervisor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
+ Coverage   59.69%   59.72%   +0.03%     
==========================================
  Files          64       64              
  Lines        5438     5443       +5     
  Branches      591      591              
==========================================
+ Hits         3246     3251       +5     
  Misses       2048     2048              
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoh hoh merged commit 4f9b3e6 into main Jun 27, 2024
@hoh hoh deleted the hoh-sevctl-from-settings branch June 27, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLUE This PR is simple and straightforward.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants