Fix: No .deb was built for Ubuntu 24.04 #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
BLACK
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
=======================================
Coverage 57.92% 57.92%
=======================================
Files 60 60
Lines 5402 5402
Branches 600 600
=======================================
Hits 3129 3129
Misses 2133 2133
Partials 140 140 ☔ View full report in Codecov by Sentry. |
olethanh
approved these changes
Jun 3, 2024
Collaborator
olethanh
left a comment
olethanh
left a comment
There was a problem hiding this comment.
lgtm.
Outside of the scope of this PR but it doesn't really make sense that the packet we are testing in the matrix droplet as the one we build here.
This adds support in the packaging/Makefile and in the CI to build packages for Ubuntu 24.04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support in the packaging/Makefile and in the CI to build packages for Ubuntu 24.04