Feature: allow IPv6 DNS #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MHHukiewitz
approved these changes
Jan 29, 2024
|
This needs to be rebased on top of the current main branch. |
MHHukiewitz
force-pushed
the
fix_ipv6_nameservers
branch
from
8bf0bf5 to
8fec59c
Compare
hoh
reviewed
Jan 30, 2024
olethanh
force-pushed
the
fix_ipv6_nameservers
branch
from
8fec59c to
f1b7839
Compare
olethanh
force-pushed
the
fix_ipv6_nameservers
branch
from
04fe113 to
2d73fe5
Compare
Problem IPv6 DNS were automatically filtered when detected from resolvectl Solution: Nameservers are now split into ipv4 and ipv6 and can be passed to the VM accordingly At the moment we pass them if the ipv6 parameter is present on the tap interface but we need a more robust detection method
olethanh
force-pushed
the
fix_ipv6_nameservers
branch
from
6dbfd7f to
c5f09cf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
==========================================
- Coverage 62.64% 62.58% -0.06%
==========================================
Files 69 69
Lines 6131 6140 +9
Branches 490 496 +6
==========================================
+ Hits 3841 3843 +2
- Misses 2146 2147 +1
- Partials 144 150 +6 ☔ View full report in Codecov by Sentry. |
Antonyjin
pushed a commit
that referenced
this pull request
Nov 19, 2024
* Feature: allow IPv6 DNS Problem IPv6 DNS were automatically filtered when detected from resolvectl Solution: Nameservers are now split into ipv4 and ipv6 and can be passed to the VM accordingly At the moment we pass them if the ipv6 parameter is present on the tap interface but we need a more robust detection method * Display proper env conf
Antonyjin
pushed a commit
that referenced
this pull request
Nov 19, 2024
* Feature: allow IPv6 DNS Problem IPv6 DNS were automatically filtered when detected from resolvectl Solution: Nameservers are now split into ipv4 and ipv6 and can be passed to the VM accordingly At the moment we pass them if the ipv6 parameter is present on the tap interface but we need a more robust detection method * Display proper env conf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem IPv6 DNS were automatically filtered when detected from resolvectl
Solution: Nameservers are now split into ipv4 and ipv6 and can be passed to the VM accordingly At the moment we pass them if the ipv6 parameter is present on the tap interface but we need a more robust detection method.
This is an alternative implementation of #378.
As @odesenfans said in the other thread ideally , we should have the supervisor and runtime communicate to us if they support ipv6 and then only pass the ipv6 nameservers not sure if someone know a way to do that or if it's a new spec we should come up with? Also don't know if it's a blocker