Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Oct 31, 2024

Related Jira tickets : ALEPH-279

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Documentation

The documentation regarding the impacted features is available on:

URL

The changes in the documentation are available here:

URL

Changes

Changed the aleph_message dependency to use the last version with new EVM definitions.
Also changed the dependency of aleph-sdk-python to get the last version with new EVMs.

How to test

Set the account chain to one of the new ones and try to sign and send a message, like "CHAIN": "POL".

Notes

This PR should be merged before at the deployment time.

@nesitor nesitor self-assigned this Oct 31, 2024
@nesitor nesitor force-pushed the andres-feature-implement_new_evm_chains branch from 85fe97f to 53b0522 Compare October 31, 2024 23:29
@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.85%. Comparing base (b3d00dc) to head (399388e).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/account.py 83.33% 0 Missing and 1 partial ⚠️
src/aleph_client/commands/instance/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
+ Coverage   39.82%   39.85%   +0.03%     
==========================================
  Files          18       18              
  Lines        2117     2120       +3     
  Branches      257      258       +1     
==========================================
+ Hits          843      845       +2     
  Misses       1222     1222              
- Partials       52       53       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor marked this pull request as ready for review November 1, 2024 12:00
@aleph-im aleph-im deleted a comment from github-actions bot Nov 4, 2024
@nesitor nesitor force-pushed the andres-feature-implement_new_evm_chains branch from 459e21e to 86610a8 Compare November 4, 2024 16:57
@nesitor nesitor merged commit de0e44c into master Nov 4, 2024
16 checks passed
@nesitor nesitor deleted the andres-feature-implement_new_evm_chains branch November 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants