Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update playwright version, add basic tests #103

Merged
merged 1 commit into from
Mar 9, 2024
Merged

update playwright version, add basic tests #103

merged 1 commit into from
Mar 9, 2024

Conversation

AxiomPraxis
Copy link
Contributor

Bumped the playwright version (to match VSCode extension for testability purposes)
Also corrected path for the placeholder image in /library (it was throwing an error).

Added some basic UI tests for each of the 4 main pages:

  1. Main (/)
  2. Library (/library)
  3. Sources (/sources)
  4. Settings (/settings)

If these are satisfactory (or not), or if you want any specifics as to what each test or test step does, please let me know.

I can expand on them and make them more modular or if you have any specifics you would like added, please also let me know.

Cheers

@AxiomPraxis
Copy link
Contributor Author

I believe this also may address #60

@AxiomPraxis
Copy link
Contributor Author

Reviewing this again, may want to drop the package.json and package-lock.json changes and just keep the rest, it may have thrown some arm64/darwin changes into the package-lock, and I don't want to mess with the build process. the tests should still work fine on the older version.

@jordanf97
Copy link
Contributor

it may have thrown some arm64/darwin changes into the package-lock

Looks fine to me, won't break anything 👍

@aleksilassila
Copy link
Owner

Thanks for the contribution! I haven't had time to think about the tests, so these kinds of sanity checks will do nicely. One thing I noticed was that it's probably a good idea to not check if the default values for settings exist as the test will fail if the settings have been changed. Also the first check of finding "Home" element times out for me for some reason. Will merge this anyway, this is a good base for future improvements.

@aleksilassila aleksilassila merged commit 4a28ad5 into aleksilassila:dev Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants