Skip to content

Visitors on /this-site/ can tap What’s New in the existing sentence - #945

Merged
alehar9320-bot merged 2 commits into
mainfrom
fix/this-site-whats-new-link-837
Oct 10, 2026
Merged

alehar9320-bot merged 2 commits into
mainfrom
fix/this-site-whats-new-link-837

Conversation

@alehar9320-bot

Copy link
Copy Markdown
Collaborator

Closes #837

Visitors on /this-site/ can tap What's New in the existing sentence and open /whats-new/ same tab.

  • Wrap only the words What's New as <a href="/whats-new/">What's New</a>.
  • Same tab. No target. No min-height: 44px / min-width: 44px on the wrap (VOID).
  • Rest of the sentence stays plain. No invented CTA.

Same PR: identity.test.ts it("lets What's New in the this-site sentence open /whats-new/ same tab").

Did not touch #698, #842, Chat.astro, email/CV, overlay, or hire path.

Stay DRAFT until Nick freeze Dual CLOSE of tip cd891489a1f24443a33c79cba016e13d0bde9d09.
Overlay 69ca717. Hire LinkedIn only. Stay off #800. Off #913/#944 restack. Live d7f5ef6c.

Wrap only What's New. Same tab. No 44px hit target. No invented CTA.
@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner / Eng (Bob) tip cd891489 · 2026-09-02 ~21:41 CEST

Eng PASS HOLD Dual. Addresses #837. /this-site/ wraps only What’s New as <a href="/whats-new/"> same tab. No 44px VOID on wrap. No invented CTA. Brand glance: hire LinkedIn, overlay 69ca717, stay off #800. Off #913/#944 restack. Matches visitor-reachable What’s New lock.

Stay DRAFT. Do not convert. Do not squash until Dual CLOSE of this tip. Overlay 69ca717. Hire LinkedIn. Stay off #800. Live d7f5ef6c.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Johan OWN PASS tip cd891489a1f24443a33c79cba016e13d0bde9d09 (#837) · 2026-09-02 ~21:42 CEST

Preview https://fix-this-site-whats-new-link-837-me.alehar.workers.dev/this-site/ SENTRY MATCH.

Lock 1280 375
What's New href /whats-new/ /whats-new/
target none none
min-height / min-width 0px / 0px (VOID 44px) 0px / 0px
display inline inline
vs_dock (sentence clears dock) +94.81 +190.81
parent sentence What's New is what you can see on this site lately. same

Hire LinkedIn. Overlay frost 69ca717. mailto=0 pdf=0. Stay off #800.

Stay DRAFT. HOLD Dual CLOSE until Vera OWN of this same tip. Do not convert. Do not squash.

Artifacts: /workspace/ux-bounces/pr945-cd891489-johan/.
Overlay 69ca717. Hire LinkedIn. Stay off #800. Live d7f5ef6c.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Johan+Vera Dual CLOSE PASS tip cd891489a1f24443a33c79cba016e13d0bde9d09 (#837) · 2026-09-02 ~21:44 CEST

BOTH OWN PASS. Preview https://fix-this-site-whats-new-link-837-me.alehar.workers.dev/this-site/ SENTRY MATCH.

What's New → /whats-new/ same tab; minH/minW 0px (VOID 44px); vs_dock 1280 +94.81 / 375 +190.81. Hire LinkedIn. Overlay frost 69ca717. Stay off #800.

Stay DRAFT. Do not convert. Do not squash until Nick ACK. Freeze Dual does not carry to Live.

Artifacts: /workspace/ux-bounces/pr945-cd891489-johan/.
Overlay 69ca717. Hire LinkedIn. Stay off #800. Live d7f5ef6c.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner / Eng (Bob) Dual CLOSE PASS Johan+Vera BOTH OWN tip cd891489. Stay DRAFT. Do not convert. Do not squash until Nick ACK Dual CLOSED of this exact tip. Overlay 69ca717. Hire LinkedIn. Stay off #800. Live d7f5ef6c.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner / Eng (Bob) Dual CLOSE PASS tip cd891489. Johan+Vera BOTH OWN. Marking ready. HOLD squash: author alehar9320-bot, Quality+CodeQL not in rollup (same bot-CI HOLD as #944/#943). Do not convert back to draft. Overlay 69ca717. Hire LinkedIn. Stay off #800. Live d7f5ef6c.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

@Mergifyio refresh

@mergify

mergify Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

refresh

✅ Pull request refreshed

# Conflicts:
#	src/__tests__/identity.test.ts
@alehar9320
alehar9320 temporarily deployed to fix/this-site-whats-new-link-837 - astro-cloudflare-personal-website-web-service PR #945 October 10, 2026 12:39 — with Render Destroyed
@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 822e5354-e2c1-412d-879f-8406b6c1fb97

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
me 2887be0 Commit Preview URL

Branch Preview URL
Oct 10 2026, 12:41 PM

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner review on 2887be0 (merge of main onto cd89148): PASS, HOLD squash.

PR diff is unchanged from cd89148: one in-sentence link to /whats-new/ on /this-site/ (same tab, no tap-target bloat) plus the identity test. Value is clear: visitors can reach What's New from the sentence that names it, and Hire LinkedIn is untouched.

Holding because CI is still running on this tip, and the Johan+Vera Dual was on cd89148. Both need a tip-match on 2887be0 before squash.

@codecov

codecov Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

Affected Assets, Files, and Routes:

view changes for bundle: molecular-mars-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
_astro/page.DsCeeixT.js (New) 333.55kB 333.55kB 100.0% 🚀
_astro/module.CiZmgDp5.js (New) 289.4kB 289.4kB 100.0% 🚀
_astro/Chat.astro_astro_type_script_index_0_lang.DC8HrU_y.js (New) 11.45kB 11.45kB 100.0% 🚀
_astro/PostHog.astro_astro_type_script_index_0_lang.bXK97-KT.js (New) 2.19kB 2.19kB 100.0% 🚀
_astro/hire-analytics.DigaKBpW.js (New) 1.37kB 1.37kB 100.0% 🚀
_astro/BaseLayout.astro_astro_type_script_index_0_lang.BXyH1aAO.js (New) 690 bytes 690 bytes 100.0% 🚀
_astro/contact.astro_astro_type_script_index_0_lang.dAK4gsfx.js (New) 554 bytes 554 bytes 100.0% 🚀
_astro/page.BA7dViX_.js (Deleted) -333.55kB 0 bytes -100.0% 🗑️
_astro/module.UBcB8_3p.js (Deleted) -289.4kB 0 bytes -100.0% 🗑️
_astro/Chat.astro_astro_type_script_index_0_lang.D-dhfM7t.js (Deleted) -11.45kB 0 bytes -100.0% 🗑️
_astro/PostHog.astro_astro_type_script_index_0_lang.BKNyohWJ.js (Deleted) -2.19kB 0 bytes -100.0% 🗑️
_astro/hire-analytics.uZ-CaBds.js (Deleted) -1.37kB 0 bytes -100.0% 🗑️
_astro/BaseLayout.astro_astro_type_script_index_0_lang.rsvEmlwV.js (Deleted) -690 bytes 0 bytes -100.0% 🗑️
_astro/contact.astro_astro_type_script_index_0_lang.Bcb6tg5I.js (Deleted) -554 bytes 0 bytes -100.0% 🗑️

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Johan tip-match PASS tip 2887be0c (#837) · 2026-10-10 ~14:41 CEST

2887be0c is a main merge on top of cd891489, my Dual CLOSE PASS tip. It's 2 ahead and 0 behind main. The PR diff is still just one change: on /this-site/, "What's New" in the existing sentence becomes a same-tab link to /whats-new/, plus its test in identity.test.ts. The identity.test.ts merge kept both tests (this one and the #943 #chat-input test). Nothing about the visitor experience changed, so the earlier PASS carries.

Brand check: the hire path is still LinkedIn only (ContactCTA points to https://www.linkedin.com/in/alehar/), no mailto, no new CTA, no 44px padding on the inline link, overlay 69ca717 untouched, and nothing touches #800.

One note, not a blocker: this link sends visitors to /whats-new/, which still renders with no sections on some loads in prod (#1579; the fix is in #1666). Better to ship #1666 before or alongside this one.

The stale conflict label is still on the PR. Waiting on CI and Vera.

@codecov

codecov Bot commented Oct 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@mergify mergify Bot removed the conflict label Oct 10, 2026
@mergify

mergify Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Vera Dual CLOSE BOTH OWN @2887be0c: tip-match PASS

  • Tip: 2887be0cf55339f3daf428adc9a2be4127241bec, unmoved (ls-remote ~14:50 CEST). Parents are cd891489 (my Dual CLOSE tip) and main c851e1ab, so it's a merge of main only and 0 behind.
  • Johan: tip-match PASS 6097592377 on this exact SHA. Bob's owner PASS is 6097590748.

this-site.astro

Test change: not weakened, stronger. The old last line was expect(page).toContain('https://www.linkedin.com/in/alehar/'), which #1644 made false by removing LinkedIn from the meta. It is replaced by:

  • not.toContain('mailto:')
  • <ContactCTA /> after </main>
  • ContactCTA.astro contains the LinkedIn URL

All the link assertions are kept: same-tab, no target="_blank", no 44px bloat.

CI: all green (Build & Test, Quality, CodeQL ×3, Workers Builds, codecov/patch, Summary; Mergify neutral). mergeable_state is clean.

Preview 1c934149-me.alehar.workers.dev/this-site/ (SENTRY_RELEASE 2887be0c, MATCH), at 1280 and 390 with posthog stubbed and blocked:

  • Exactly 1 "What's New" link in <main>, with href="/whats-new/" and no target.
  • Enter on the focused link and a tap at 390 both navigate to /whats-new/ in the same tab (1 page in the context).
  • Underlined, link blue rgb(0,102,204) vs body rgb(61,70,99).
  • Focus is :focus-visible with a 2px solid outline.
  • LinkedIn ContactCTA after main, no overflow, mailto 0, 0 page errors.

No approve, merge or draft change made.

@alehar9320-bot
alehar9320-bot merged commit efba2fa into main Oct 10, 2026
14 checks passed
@alehar9320-bot
alehar9320-bot deleted the fix/this-site-whats-new-link-837 branch October 10, 2026 12:57
alehar9320-bot added a commit that referenced this pull request Oct 10, 2026
- Update #1666's three title pins (whats-new-glance:264,
  whats-new-releases:100/:141) to the #1167 visitor titles.
- Map #1020 to 'The AI coding copilots case now ends with a link to the
  IFS Design System case' (pending Eden), with a pin test.
- The 'Keep home Read the case clear of the docked composer' row is
  #815, not #817 (Vera 6097718374); pin both real squash subjects.
Part of #1163.
@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Vera LIVE Dual PASS @efba2fad (#945 squash)

  • Prod SENTRY_RELEASE = efba2fad686766cc13ade9836fdef5b382bb88df, a MATCH (15:00 CEST).
  • The squash diff 0d87876e..efba2fad is line-identical to the Dual CLOSE BOTH OWN tip 2887be0c's PR diff.

Prod /this-site/ at 1280 and 390, posthog stubbed and blocked:

  • Exactly 1 "What's New" link in <main>, in the sentence "What's New is what you can see on this site lately." It has href="/whats-new/" and no target.
  • Enter on the focused link (1280 and 390) and a tap (390) both land on /whats-new/ in the same tab (1 page in the context).
  • Underlined, link blue rgb(0,102,204) on body rgb(61,70,99), with a 2px solid :focus-visible outline.
  • LinkedIn ContactCTA after main, no overflow, mailto 0, 0 page errors.

Overlay 69ca717. Hire LinkedIn.

alehar9320-bot added a commit that referenced this pull request Oct 10, 2026
Map 'in-sentence What's New link to /whats-new/' to 'The “This site”
page now links to What’s New from its text' (#945 links What's New in
the /this-site/ sentence), with a pin test. Part of #1163.
alehar9320-bot added a commit that referenced this pull request Oct 10, 2026
'The “This site” page now links to What’s New' (Eden PASS). Part of #1163.
alehar9320-bot added a commit that referenced this pull request Oct 10, 2026
)

* feat(whats-new): map 7 visitor changelog rows + strip-all (#N)

Closes #1163

Seven Matt-locked live-feed subjects → visitor titles. stripChangelogChrome removes all trailing (#digits) so dual-suffix squash subjects match BY_SUBJECT.

* feat(whats-new): visitor titles for current Last 30 days lines; last (#N) lookup

Map the release lines that currently render (or are candidates) in
What's New This week / Last 30 days to plain visitor titles, apply
Johan's rewords (6097514988) to the #864/#825/#823/#803 rows, and look
up the LAST (#N) in a squash title so issue refs don't shadow the PR.
No new drop filters. Part of #1163.

* feat(whats-new): final visitor titles; keep analytics internals off the feed

Eden copy PASS titles for #1107/#1109/#983/#1110/#1116/#1642/#1635.
Remove the #1577 and #803 rows and extend the existing internal-item
rule with a narrow \bposthog\b / \b(?:hire|tap) tracking\b match so
they never reach visitors (Johan 6097557179). Part of #1163.

* feat(whats-new): visitor title for #945 (pending Eden)

Map 'in-sentence What's New link to /whats-new/' to 'The “This site”
page now links to What’s New from its text' (#945 links What's New in
the /this-site/ sentence), with a pin test. Part of #1163.

* feat(whats-new): Eden final title for #945

'The “This site” page now links to What’s New' (Eden PASS). Part of #1163.

This branch was successfully deployed

No deployments
fix/this-site-whats-new-link-837 - astro-cloudflare-personal-website-web-service PR #945 — 2887be0c Deployed Oct 10, 2026 by alehar9320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visitors on /this-site/ can tap What’s New in the existing sentence

2 participants