Repository navigation
docs(context): tighten LinkedIn scrape redaction (#1639 follow-up) - #1641
Conversation
Drop viewer follow-button state (FollowingPremium / Following) from the scrape, add a redaction header note, fix the 'initiative.IFS' glue, widen the context/ privacy test's banned list and resolve context/ from the test file location instead of process.cwd().
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
me | 23d1fad | Commit Preview URL Branch Preview URL |
Oct 09 2026, 08:29 AM |
Bundle ReportBundle size has no change ✅ Affected Assets, Files, and Routes:view changes for bundle: molecular-mars-esmAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Add a space after the period in three '…see more' joins (work with. IFS, at hand. Invativa, leadership. Activities). Ban 'who your viewers also viewed' in the context/ privacy test, and list the 'used by millions' reach claim as do-not-ship in identity.md.
|
Owner review on tip 23d1fad: PASS on value. This is docs + test only, it changes no public facts, and visitor pages are untouched. It tightens the public Soft nit (non-blocking): HOLD: still draft and CI is in progress. Squash once CI is green and Johan + Vera Dual is on this tip. The Codecov bundle +116% is a baseline artifact (the PR has no src/runtime changes), so ignore it. |
|
Johan (UX): Dual OWN PASS on This touches only CI is green and the PR merges cleanly. Squash is clear on my side, with Vera's OWN per the usual flow. Overlay 69ca717. Hire LinkedIn. |
Vera Dual OWN PASS WITH NITS on
|
Vera soft nits on #1641 (6077408474): ban 'open to work' and the LinkedIn label 'open to:' instead of bare 'open to', so prose like 'open to collaboration' doesn't fail CI; keep 'premium' and all other entries. Mark the inline 'used by millions' in context/identity.md L13 '(do not ship)'.
…design-system CTA (#1638) * fix(hire): count /work/ second Get in touch link The in-main 'Get in touch on LinkedIn' link on /work/ had no data-hire-* attributes, so hire clicks from it were not counted. Tag it with the same event as the other hire CTAs (hire_cta_click) and its own surface (work_page). Copy, href and styles unchanged. * test(hire): match /work/ LinkedIn href with an anchored regex CodeQL flagged js/incomplete-url-substring-sanitization on the includes() URL check in the new /work/ hire test. Match the exact href attribute instead. * test(hire): lock /work/ ContactCTA hire attrs, drop moot second-link test #1109 removed the in-main /work/ hire link, so the 'exactly 2 tagged links' test no longer applies. Assert instead that /work/ renders ContactCTA with data-hire-event="hire_cta_click" and data-hire-surface="contact_cta" (Vera nit 1 on #1109). * fix(work): drop phone FAB-clearance bottom padding after Earlier work ContactCTA now follows Earlier work directly and carries its own FAB clearance, so .earlier's phone padding-bottom: var(--chat-fab-clearance) (100px) only added blank space (last item to CTA heading 261px -> 161px at 390x844). Desktop was already padding-bottom: 0 and is unchanged. The older FAB lock now asserts work.astro has no FAB padding-bottom; padding-right stays. Vera nit 2 on #1109. * fix(hire): count IFS Design System case Get in touch (#979) The in-body 'Get in touch on LinkedIn' on /work/ifs-design-system/ had no data-hire-* attributes, so clicks were not counted. Tag it data-hire-event="hire_cta_click" data-hire-surface="case_study", add case_study to HireSurface, and lock it in identity.test.ts. Copy, href and styles unchanged. * docs(context): narrow 'open to' ban, fence inline 'used by millions' Vera soft nits on #1641 (6077408474): ban 'open to work' and the LinkedIn label 'open to:' instead of bare 'open to', so prose like 'open to collaboration' doesn't fail CI; keep 'premium' and all other entries. Mark the inline 'used by millions' in context/identity.md L13 '(do not ship)'.
Follow-up to #1639 (which followed #885). Covers Vera's nits on
context/author-linkedin.mdand the context/ privacy test. This PR changes docs and one test only.context/author-linkedin.md• FollowingPremium • Followingunder Christian Pedersen's reposted post.Followingbuttons in Interests → Top Voices (Cassie Kozyrkov and Marc Randolph), plus their blank spacer lines. The Top Voices entries themselves stay.context/is locked bycontext-privacy.test.ts.initiative.IFS→initiative. IFS. It occurred once.src/__tests__/context-privacy.test.tscontext/for each one. The only hit waspremiumin L117, which this PR removes. No public text oridentity.mdrule needed rewording.context/is now resolved from the test file's own location (fileURLToPath(import.meta.url)), not fromprocess.cwd().context/, the widened test fails ("premium"). On this branch it passes, including when vitest is run from a different working directory.Second commit (Vera + Johan comment 6077135635)
author-linkedin.md: I added the missing space after the period in three more sentence joins:work with. IFS(L162),business case at hand. Invativa(L184) andleadership. Activities(L214). A search for[a-z]\.[A-Z]now finds no prose joins. URLs and abbreviations are untouched.context-privacy.test.ts: addedwho your viewers also viewedto the banned list. A search ofcontext/before the change found no match.identity.md→ "Private / do not ship on visitor pages": added a rule saying the "used by millions" reach claim from the GitHub profile README must not ship on visitor pages. The phrase also appears inidentity.mdL13, which describes the GitHub profile README source. I left that line as is: it describes the source, and the test doesn't ban the phrase.The removed text still exists in git history. Whether to purge it is Alexander's decision.
Local checks (Node 22):
npm testpassed (23 files, 390 tests).npm run lintandnpm run format:checkare clean.