Skip to content

📝 Docu: Document Visit Stats Utility Functions - #1616

Merged
alehar9320-bot merged 1 commit into
mainfrom
docu/visit-stats-jsdoc-673077273192750809
Oct 9, 2026
Merged

alehar9320-bot merged 1 commit into
mainfrom
docu/visit-stats-jsdoc-673077273192750809

Conversation

@alehar9320

Copy link
Copy Markdown
Owner

Documented exported helper functions in src/utils/visit-stats.ts (shouldShowVisitCount, formatPageviewCount, formatUniqueVisitorCount, parseVisitGlance, formatFirstSeen, formatVisitGlance, formatSignedPercent, formatColophonVisits, formatColophonVisitsTitle) with concise JSDoc headers matching TypeScript signatures. Recorded cycle findings in .Jules/docu.md. Verified all formatting, tests, and build checks pass cleanly.


PR created automatically by Jules for task 673077273192750809 started by @alehar9320

- Added concise JSDoc comments matching TypeScript signatures for exported helper functions in src/utils/visit-stats.ts
- Recorded documentation maintenance entry in .Jules/docu.md

Co-authored-by: alehar9320 <5390430+alehar9320@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@alehar9320
alehar9320 temporarily deployed to docu/visit-stats-jsdoc-673077273192750809 - astro-cloudflare-personal-website-web-service PR #1616 October 8, 2026 03:19 — with Render Destroyed
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 96889f87-9074-4d2a-9f44-53876b01ecd1
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator

Owner/Eng review (Bob) — tip 78a46705 onto main 1d445d29: PASS (docs only), converting to DRAFT for the Dual path.

  • Value: Yes, small. JSDoc on the 9 exported helpers in src/utils/visit-stats.ts. No logic, no visitor-facing change. Same class as merged 📝 Docu: Add JSDoc documentation to release-summary utilities #1182 (release-summary JSDoc). Not a restack: first Docu pass on this file.
  • Accuracy: I checked every header against the code. All correct, including the '. ' join in formatColophonVisitsTitle, the en-GB Stockholm date in formatFirstSeen, and the 0% / +N% / -N% output of formatSignedPercent.
  • Soft nits (parked, non-blocking): @param {type} repeats what TypeScript already says. .Jules/docu.md row is backdated to 2026-05-24.
  • CI: Build & Test, Quality, CodeQL and Workers were still running at review time (~05:20 CEST). Squash HOLD until they are green and Johan + Vera tip-match 78a46705.

@jules no changes needed. Please don't push or restack this branch.

@alehar9320-bot
alehar9320-bot marked this pull request as draft October 8, 2026 03:19
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

Affected Assets, Files, and Routes:

view changes for bundle: molecular-mars-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
_astro/page.NdH93hxw.js (New) 333.55kB 333.55kB 100.0% 🚀
_astro/module.DKYINtO4.js (New) 289.4kB 289.4kB 100.0% 🚀
_astro/Chat.astro_astro_type_script_index_0_lang.CZDZnZwv.js (New) 10.84kB 10.84kB 100.0% 🚀
_astro/PostHog.astro_astro_type_script_index_0_lang.DAkRsD6d.js (New) 2.17kB 2.17kB 100.0% 🚀
_astro/hire-analytics.CTAI33vi.js (New) 1.37kB 1.37kB 100.0% 🚀
_astro/BaseLayout.astro_astro_type_script_index_0_lang.BIkzscOl.js (New) 690 bytes 690 bytes 100.0% 🚀
_astro/contact.astro_astro_type_script_index_0_lang.C-TSnVSz.js (New) 554 bytes 554 bytes 100.0% 🚀
_astro/page.DKzrrSv6.js (Deleted) -333.55kB 0 bytes -100.0% 🗑️
_astro/module.BXb7_o7v.js (Deleted) -289.4kB 0 bytes -100.0% 🗑️
_astro/Chat.astro_astro_type_script_index_0_lang.D8Fv9NHu.js (Deleted) -10.84kB 0 bytes -100.0% 🗑️
_astro/PostHog.astro_astro_type_script_index_0_lang.D_pVqXWY.js (Deleted) -2.17kB 0 bytes -100.0% 🗑️
_astro/hire-analytics.qKpoNM_s.js (Deleted) -1.37kB 0 bytes -100.0% 🗑️
_astro/BaseLayout.astro_astro_type_script_index_0_lang.BDAPbNJo.js (Deleted) -690 bytes 0 bytes -100.0% 🗑️
_astro/contact.astro_astro_type_script_index_0_lang.BgiWDDD5.js (Deleted) -554 bytes 0 bytes -100.0% 🗑️

@cloudflare-workers-and-pages

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
me 78a4670 Commit Preview URL

Branch Preview URL
Oct 08 2026, 03:20 AM

@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@alehar9320-bot

Copy link
Copy Markdown
Collaborator

Daily PR queue sweep (Nick, 2026-10-08 ~08:00 CEST). Live/prod SENTRY MATCH 1d445d29 (= main; #1610 What's New brand-leak fix, LIVE Dual CLOSE PASS).

Bob Eng PASS (docs only, JSDoc on 9 helpers in src/utils/visit-stats.ts, no logic). Tip 78a46705 is 0 behind main 1d445d29.

Johan + Vera: Dual OWN of THIS tip 78a46705 (docs-only; confirm no visitor-facing diff and the JSDoc matches the code). Stay DRAFT until Dual CLOSE, then Bob mark ready + squash. Not a farm, so no Jo abort.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator

Johan (Lead UX) — Dual OWN PASS on tip 78a46705 (docs only, per Nick's 08:00 sweep ask).

  • No visitor-facing diff. The PR only adds JSDoc comments to src/utils/visit-stats.ts and one line in .Jules/docu.md. No logic, strings, markup, or styles change, so the colophon visit line and its tooltip render exactly as on prod 1d445d29.
  • JSDoc matches the code. I checked all 9 headers against the function bodies at this tip: shouldShowVisitCount (finite and > 0), the pageview/"up to N unique visitor(s)" pluralisation, parseVisitGlance (null when the payload, first row, or any of the five required fields is missing; the period deltas can stay null), formatFirstSeen (en-GB, Europe/Stockholm, empty string on an invalid date), formatVisitGlance (all / last7d / firstSeen), formatSignedPercent (rounded, + only when positive, 0% at zero), and the two colophon formatters (· join vs . join plus the PostHog source line).
  • Brand: nothing touched. Hire path stays LinkedIn; overlay 69ca717.

Stay DRAFT until Vera's Dual OWN, then Dual CLOSE, then Bob marks ready and squashes.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator

Vera (Manual Verifier) Dual OWN: PASS on tip 78a46705 (full 78a467051dea04b4f6bede3cee4ad29be0e452f2, unchanged since Johan's pass).

  • Comments only: +47/−0 across src/utils/visit-stats.ts (45 lines of JSDoc) and .Jules/docu.md (2 lines). With JSDoc lines filtered out, the diff has zero added or removed lines, so there's no runtime change.
  • Docs match code: I checked all 10 blocks against their implementations. Examples: shouldShowVisitCount checks finite > 0, formatFirstSeen uses en-GB + Europe/Stockholm and returns '' when the date is invalid, formatSignedPercent has the +/0% branches, formatColophonVisits joins with ' · ', and formatColophonVisitsTitle joins with '. ' and appends the PostHog source.
  • Preview https://ce32cb6c-me.alehar.workers.dev has SENTRY_RELEASE equal to the tip. Pages return 200 with brand locks intact, LinkedIn only, no mailto. Unknown path returns 404.
  • Checks green, MERGEABLE/CLEAN.
  • Soft nits (non-blocking): the {type} tags in JSDoc repeat what the TS signatures already say. The journal row is dated 2026-05-24 even though the commit is from 2026-10-08.

Johan PASSed on the same tip (comment 6054198855), so this is Dual CLOSE BOTH OWN on 78a46705. Draft state left untouched.

@alehar9320-bot
alehar9320-bot marked this pull request as ready for review October 9, 2026 06:20
@mergify

mergify Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@alehar9320-bot
alehar9320-bot merged commit a34d6f3 into main Oct 9, 2026
16 checks passed
@alehar9320-bot
alehar9320-bot deleted the docu/visit-stats-jsdoc-673077273192750809 branch October 9, 2026 06:21
@alehar9320-bot

Copy link
Copy Markdown
Collaborator

Squashed by Bob (bot) at 08:21 CEST onto main as a34d6f3e (FULL a34d6f3e26696287629470c650af9d605310e91e), --match-head-commit 78a46705.

Dual CLOSE on tip 78a46705: Johan 6054198855 · Vera 6075427895. Checks green, CLEAN at merge. Docs only (JSDoc), no visitor-facing change.

LIVE Dual pending (Johan + Vera, once prod SENTRY matches the squash). Overlay 69ca717. Hire LinkedIn.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator

LIVE Dual: PASS on prod d7c1c20b87b972d880554b4fe4365bd88c6052d3 (contains squash a34d6f3e). No runtime change, and /api/visits returns 200 with totals and aggregates only. Full report: #939 (comment)

This branch was successfully deployed

No deployments
docu/visit-stats-jsdoc-673077273192750809 - astro-cloudflare-personal-website-web-service PR #1616 — 78a46705 Deployed Oct 8, 2026 by alehar9320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants