Skip to content

Hiring managers on Biography take internal AI coding copilots to the case, not only plain text - #1034

Merged
alehar9320-bot merged 2 commits into
mainfrom
fix/1028-biography-copilots-link
Oct 10, 2026
Merged

alehar9320-bot merged 2 commits into
mainfrom
fix/1028-biography-copilots-link

Conversation

@alehar9320-bot

Copy link
Copy Markdown
Collaborator

Fixes #1028

Summary

  • Biography Feb 2025 timeline: link internal AI coding copilots → /work/ai-coding-copilots/
  • IFS Design System link + LinkedIn left as-is
  • Identity lock for the copilots href

Stay DRAFT until Dual CLOSE. Overlay 69ca717. Hire LinkedIn. Stay off #800. Live 94d2392.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Johan Dual OWN PASS #1034/#1028 tip 1d90c976 (1d90c97605f52eff39054e7759eb74f6aa64c9ea)

Preview https://8cfa3a10-me.alehar.workers.dev — SENTRY MATCH (alias https://fix-1028-biography-copilots-link-me.alehar.workers.dev).

Visitor / taste

  • /biography/ Feb 2025 timeline: a[href="/work/ai-coding-copilots/"] with text internal AI coding copilots.
  • IFS Design System link + LinkedIn left as-is. No invented metrics. Elevated taste PASS (proof path on plain mention; no new chrome).

Brand

  • Hire LinkedIn https://www.linkedin.com/in/alehar/ — 0 mailto, 0 PDF, 0 Lidköping.
  • Soft dims parked. Overlay 69ca717. Stay off #800.

Stay DRAFT HOLD Vera Dual OWN then Dual CLOSE. Soft dims parked. Overlay 69ca717. Hire LinkedIn. Stay off #800. Stay off Lidköping. Live 94d23920.

@alehar9320-bot
alehar9320-bot marked this pull request as ready for review September 4, 2026 11:31
@alehar9320-bot alehar9320-bot mentioned this pull request Sep 4, 2026
@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

@Mergifyio refresh

@mergify

mergify Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

refresh

✅ Pull request refreshed

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Johan (Lead UX) — Dual OWN PASS WITH NITS on 1d90c976 (1d90c97)

Still worth it: yes. On main, the Biography Feb 2025 row still says "including internal AI coding copilots" as plain text, while the IFS Design System row already links to its case. Linking it gives hiring managers the same continue-to-proof path.

  • The copy is unchanged. It still says "I work on", so there's no role inflation and no new claims.
  • The link inherits .content :global(a) (no new radius, shadow or glow).
  • The test passes locally, and its linkedin.com/in/alehar assertion still holds after Biography: Get in touch from chrome only (#1103) #1107 via JSON-LD sameAs.

Nits:

  1. The one-line <p>…<a>…</a>.</p> is past the prettier width, so format:check will flag it on refresh. Wrap it like the IFS row.
  2. The copilots case is still a thin, circular stub on main. Land this with or after Hiring managers on the copilots case get a continue to IFS Design System proof, not a circular stub #1020, so the click leads somewhere that continues to proof.

Branched from Sept-4 main and CONFLICTING with 7df528c. GitHub CI hasn't run on it, so I ran the PR's own test locally on the tip. There's no current preview, so this is judged from the diff against today's main. Draft state unchanged, not closed or merged. Overlay 69ca717 untouched, hire is LinkedIn only (no mailto/CV), and #800 / Lidköping aren't touched.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Vera Dual OWN PASS WITH NITS @1d90c976 — Dual CLOSE BOTH OWN (pre-refresh)

Johan's Dual OWN PASS WITH NITS is on the same tip (6096835932).

Still worth it: yes. On main, the Biography Feb 2025 row still has "internal AI coding copilots" as plain text, while the IFS row links to its case. Linking it adds a path to the case with no new copy.

  • Diff: biography.astro ±1 (wraps the existing words in <a href="/work/ai-coding-copilots/">) + 9-line test.
  • Locks: copy is unchanged ("I work on", no inflation). LinkedIn only, mailto 0, title holds.
  • Preview 8cfa3a10-me (SENTRY MATCH, Sept base), at 1280 and 390:
    • The link is present with the text "internal AI coding copilots".
    • No overflow, 0 errors. Chat is docked at the bottom.
  • Tests: the tip passes 124/124. Applied onto main, the full suite passes 395/395.
  • Conflicts: only identity.test.ts. The intent survives.

Nits:

  1. Prettier fails on biography.astro once applied to main (the line is too long). Wrap it like the IFS row.
  2. The copilots case is still a circular stub. Land this with or after Hiring managers on the copilots case get a continue to IFS Design System proof, not a circular stub #1020, so the click leads on to proof.

Prior records on GitHub: Johan Dual OWN PASS on this same tip on 2026-09-04. No Vera record and no reviews, so there was no Dual CLOSE until now. Johan re-OWNed it today.

CONFLICTING with main 7df528c (branched from Sept main). GitHub CI hasn't run on this tip. I ran the tip's identity.test.ts locally (vitest), and separately applied the src diff onto today's main and ran main's tests. Draft state unchanged. A tip-match is needed after the refresh.

Overlay 69ca717. Hire LinkedIn.

Resolve identity.test.ts conflict by keeping every main test block and the #1028 Biography copilots test; Prettier-wrap the Biography copilots link and match it with a whitespace-tolerant regex.
@alehar9320
alehar9320 temporarily deployed to fix/1028-biography-copilots-link - astro-cloudflare-personal-website-web-service PR #1034 October 10, 2026 12:11 — with Render Destroyed
@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 740fbdc9-c5bf-4dd5-9bea-8a5182caeb40

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
me 6902a7a Commit Preview URL

Branch Preview URL
Oct 10 2026, 12:12 PM

@codecov

codecov Bot commented Oct 10, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

Affected Assets, Files, and Routes:

view changes for bundle: molecular-mars-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
_astro/page.CqGGV7r3.js (New) 333.55kB 333.55kB 100.0% 🚀
_astro/module._S32E3Kq.js (New) 289.4kB 289.4kB 100.0% 🚀
_astro/Chat.astro_astro_type_script_index_0_lang.D3Oz0uRb.js (New) 11.45kB 11.45kB 100.0% 🚀
_astro/PostHog.astro_astro_type_script_index_0_lang.BbU5CnjA.js (New) 2.19kB 2.19kB 100.0% 🚀
_astro/hire-analytics.BT-SUpy9.js (New) 1.37kB 1.37kB 100.0% 🚀
_astro/BaseLayout.astro_astro_type_script_index_0_lang.Bl6lmAhR.js (New) 690 bytes 690 bytes 100.0% 🚀
_astro/contact.astro_astro_type_script_index_0_lang.BIF8jxje.js (New) 554 bytes 554 bytes 100.0% 🚀
_astro/page.gFCvkZJx.js (Deleted) -333.55kB 0 bytes -100.0% 🗑️
_astro/module.B2FdSYHO.js (Deleted) -289.4kB 0 bytes -100.0% 🗑️
_astro/Chat.astro_astro_type_script_index_0_lang.BQl2LxEO.js (Deleted) -11.45kB 0 bytes -100.0% 🗑️
_astro/PostHog.astro_astro_type_script_index_0_lang.Bn4uMbbm.js (Deleted) -2.19kB 0 bytes -100.0% 🗑️
_astro/hire-analytics.C_-raB63.js (Deleted) -1.37kB 0 bytes -100.0% 🗑️
_astro/BaseLayout.astro_astro_type_script_index_0_lang.BA-0hrsT.js (Deleted) -690 bytes 0 bytes -100.0% 🗑️
_astro/contact.astro_astro_type_script_index_0_lang.Xj_iM23l.js (Deleted) -554 bytes 0 bytes -100.0% 🗑️

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Owner PASS @6902a7a8 (6902a7a) — HOLD squash.

New head is a merge of main (ed3b478) onto 1d90c97. The PR diff is the same intent: the Biography Feb 2025 row links "internal AI coding copilots" to /work/ai-coding-copilots/ (live, 200 on prod), copy unchanged. Prettier wrapped the anchor, and the test now matches it with a whitespace-tolerant regex while still locking the IFS Design System link, LinkedIn, and no mailto:. Rendered whitespace is fine: the > / </a\n> wrap adds no visible space inside the link or before the period.

HOLD: CI is still running, and Johan + Vera's Dual PASS WITH NITS was on 1d90c97. Both need a tip-match on 6902a7a before squash.

@codecov

codecov Bot commented Oct 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@mergify mergify Bot removed the conflict label Oct 10, 2026
@mergify

mergify Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Johan (Lead UX): tip-match PASS WITH NITS @ 6902a7a8

Against main ed3b478e the diff is still 2 files. The Feb 2025 row links "internal AI coding copilots" to /work/ai-coding-copilots/, the copy is unchanged, and Prettier's line break sits inside the tag (</a\n>.), so no stray space appears before the period. The regex test is a fair whitespace-tolerant lock. Hire stays LinkedIn and there's no mailto. With #1020 live, the copilots case now leads on to the IFS DS proof, so this link doesn't strand visitors on a thin stub.

Soft nit, non-blocking: the 44px rule covers only the IFS DS link. An inline link inside a sentence is exempt from the WCAG 2.5.8 target size, so this is fine to ship, but consider sharing one rule for both bio links next time this row is touched. Squash after Vera. Overlay 69ca717. Hire LinkedIn.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Vera tip-match PASS WITH NITS @6902a7a8 (6902a7a) — Dual CLOSE BOTH OWN (Johan 6097370147, same SHA)

This supersedes my OWN on 1d90c976 (6096874421).

Diff / tests

  • Merge of main ed3b478e onto 1d90c976. Against main it's 2 files, +15/−1.
  • biography.astro: the Feb 2025 row's "internal AI coding copilots" is wrapped in <a href="/work/ai-coding-copilots/">. The copy is otherwise unchanged, and the line break is Prettier's.
  • identity.test.ts: a new lock with the whitespace-tolerant /<a href="\/work\/ai-coding-copilots\/"\s*>internal AI coding copilots<\/a\s*>/, plus IFS DS href, LinkedIn present and no mailto.
  • Fresh npm ci worktree: 402/402, prettier clean. Pointing the link elsewhere fails the new test.
  • CI all green, CLEAN against main ed3b478e.

Preview 9c7afae6-me (SENTRY_RELEASE = 6902a7a, MATCH), /biography/ at 1280 and 390, posthog stubbed and blocked:

  • The copilots link appears once, inside <main>. Clicking it lands on "Internal AI coding copilots | Product Manager, Developer Experience at IFS", and curl returns 200.
  • Styled like the IFS DS in-body link: both are rgb(0, 102, 204), weight 400, 1px underline at the same offset. At rest the underline is transparent, and on hover (1280) the underline is accent-coloured for both. Keyboard focus is :focus-visible with a 2px solid rgb(0, 102, 204) outline.
  • Biography: Get in touch from chrome only (#1103) #1107 holds: 0 hire links and no "Get in touch" in <main>. ContactCTA is present after it.
  • Hiring managers on Biography take the M.Sc. row to the thesis case, not only plain text #1035 holds: the M.Sc. heading still links to /work/master-thesis/.
  • <main> links are copilots, IFS DS and thesis. Title locked, mailto 0, no overflow, 0 errors.

Nits (soft)

  1. Hit target: the new link is 242×24 at 1280 (200×43 at 390, where it wraps), while the IFS DS in-body link gets 44px height. The 44px treatment is worth matching in a follow-up.
  2. As on IFS DS and M.Sc., there's no visible underline at rest, so touch users rely on colour alone.

No merge, approve or draft change made. Overlay 69ca717. Hire LinkedIn.

@alehar9320-bot
alehar9320-bot merged commit c5ee1ec into main Oct 10, 2026
14 checks passed
@alehar9320-bot
alehar9320-bot deleted the fix/1028-biography-copilots-link branch October 10, 2026 12:20
@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Johan (Lead UX): LIVE Dual PASS WITH NITS, squash c5ee1eca, prod SENTRY MATCH ec1e4de7

I checked prod at https://me.alehar.workers.dev/ around 14:25 CEST. SENTRY_RELEASE is ec1e4de7664d02bcf5f3452cb3a34b0ef794ab11, which comes after c5ee1eca (#1665 landed on top). I ran headless Chrome at 1280x800 and 390x844.

  • /biography/: in the Feb 2025 row, "internal AI coding copilots" now links to /work/ai-coding-copilots/, and that page returns 200. This holds at both sizes.
  • Hire path: the page has exactly one "Get in touch". It's the chrome ContactCTA after main (y 1180 with main ending at 979 at desktop, y 1421 with main ending at 1155 at mobile), and it goes to https://www.linkedin.com/in/alehar/ with _blank + noopener noreferrer, data-hire-surface="contact_cta". There are 0 mailto and 0 PDF links.
  • No page errors at either size.
  • Soft (known): the new inline link's tap box is 242x24 at desktop and 200x43 at 390, so it's under 44px. It's an inline text link, so this doesn't block. It stays parked as before.

Overlay 69ca717 and the LinkedIn-only hire path are unchanged.

@alehar9320-bot

Copy link
Copy Markdown
Collaborator Author

Vera LIVE Dual PASS @c5ee1eca (#1034 squash), checked on prod ec1e4de7

Prod /biography/ at 1280 and 390, posthog stubbed and blocked:

No differences from the preview. The soft nit stands (24px link height vs 44px on IFS DS). Overlay 69ca717. Hire LinkedIn.

alehar9320-bot added a commit that referenced this pull request Oct 10, 2026
Resolve identity.test.ts conflict: keep the PR's #chat-input test and main's
Biography copilots continue test (#1034).

This branch was successfully deployed

No deployments
fix/1028-biography-copilots-link - astro-cloudflare-personal-website-web-service PR #1034 — 6902a7a8 Deployed Oct 10, 2026 by alehar9320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hiring managers on Biography take internal AI coding copilots to the case, not only plain text

2 participants