Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - project-local config files #51

Open
Mai-Lapyst opened this issue Oct 8, 2022 · 6 comments
Open

[FEATURE] - project-local config files #51

Mai-Lapyst opened this issue Oct 8, 2022 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Mai-Lapyst
Copy link

The extension should provide a way to allow for project-local configuration files; propably the easiest way is by supporting ${workspaceFolder} and ${workspaceRoot} in pascal.formatter.engineParameters.

@Mai-Lapyst Mai-Lapyst added the enhancement New feature or request label Oct 8, 2022
@alefragnani
Copy link
Owner

Hi @Mai-Lapyst ,

Do you mean make the parameter to support relative paths, right?

Thanks for reporting

@alefragnani alefragnani added the good first issue Good for newcomers label Oct 9, 2022
@Mai-Lapyst
Copy link
Author

This could potentially also help; but I rather ment vs-code's variables: https://code.visualstudio.com/docs/editor/variables-reference. We really only need ${workspaceFolder}; since relative paths dont work well wenn having a multi-root workspace.

@alefragnani
Copy link
Owner

We are basically describing the same thing, as ${workspaceFolder} represents the base path of the currently opened project. And in a multi-root project, it will be the base path of the root-folder of the focused/active file 😬

@Mai-Lapyst
Copy link
Author

Yeah thats what I ment too; sorry for my misunderstanding ^^'

@Merlin2001
Copy link

@alefragnani I would like to pick up this issue and just wanted to make sure there hasn't been any work done on it yet :)

Please also let me know if there's anything more I should look out for (or read beforehand), being absolutely new to VS Code extension development 🙈

@alefragnani
Copy link
Owner

Hi @Merlin2001 ,

Feel free to pick upd the issue 😬 .

About VS Code extensions development, I would looking at https://code.visualstudio.com/api/get-started/your-first-extension, with the initial steps to have an extension up and running.

This extension in particular, doesn't have anything special/complicated in terms of APIs, except the DocumentFormattingEditProvider, but you shouldn't need to touch on that. But your should probably look for https://code.visualstudio.com/api/references/vscode-api#WorkspaceConfiguration and if/how to translate variables https://code.visualstudio.com/docs/editor/variables-reference.

Feel free to open the PR, and ping me there if you need any help with it.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants