Added additional tests for Range, Clamp and Length + catch exceptions#427
Merged
alecthomas merged 3 commits intoalecthomas:masterfrom Sep 20, 2020
Merged
Added additional tests for Range, Clamp and Length + catch exceptions#427alecthomas merged 3 commits intoalecthomas:masterfrom
alecthomas merged 3 commits intoalecthomas:masterfrom
Conversation
Owner
|
Very nice, thanks! |
Collaborator
Author
|
@alecthomas Any ideas when a new release of the library will be released so that we can pull all the recent fixes into dependent projects? |
Owner
|
Hi @spacegaier , pushed up 0.12.0: https://pypi.org/project/voluptuous/0.12.0/ I'm very out of touch with the Python ecosystem at this point, so if you're interested in helping out with releases and general maintenance I'd be happy to hand over the reins. |
Collaborator
Author
|
@alecthomas I personally am rather new to the Python ecosystem, but I would be willing to help out here. And BTW: Thanks for the new release. I already triggered the dependency update in the dependent project I am contributing to (home-assistant/core#40401). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This previous PR #414 added support to catch invalid values/types for
Range. I now added that also forClampandLength.Additional I added some more tests to increase the coverage and verify the new exception handling for
ClampandLength.It would be great if after merging, a new version 0.11.8 could be created, so that depending projects (such as home-assistant where I came across those type exceptions in the first place) can easily pull in those fixes.