Date format support#234
Merged
Merged
Conversation
1 similar comment
tusharmakkar08
requested changes
Oct 24, 2016
Collaborator
tusharmakkar08
left a comment
tusharmakkar08
left a comment
There was a problem hiding this comment.
Please fix the changes requested.
| Schema(NT(int, int))(nt) | ||
| Schema(NT(int, int))(t) | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Can you add a test case where DateInvalid is catched ?
Author
There was a problem hiding this comment.
This test is already written in the 760 line
| try: | ||
| datetime.datetime.strptime(v, self.format).date() | ||
| if len(v) != len(self.FORMAT_DESCRIPTION): | ||
| raise ValueError |
Collaborator
There was a problem hiding this comment.
ValueError doesn't provide sufficient information. Use DateInvalid with different string input.
tusharmakkar08
approved these changes
Oct 25, 2016
Collaborator
|
This looks fine. Please squash your commits. |
Author
|
Done! |
This was referenced Apr 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.