Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate lexer if already registered #834

Merged
merged 1 commit into from
Aug 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,16 +172,37 @@ func (l *LexerRegistry) Analyse(text string) Lexer {
return picked
}

// Register a Lexer with the LexerRegistry.
// Register a Lexer with the LexerRegistry. If the lexer is already registered
// it will be replaced.
func (l *LexerRegistry) Register(lexer Lexer) Lexer {
lexer.SetRegistry(l)
config := lexer.Config()

l.byName[config.Name] = lexer
l.byName[strings.ToLower(config.Name)] = lexer

for _, alias := range config.Aliases {
l.byAlias[alias] = lexer
l.byAlias[strings.ToLower(alias)] = lexer
}
l.Lexers = append(l.Lexers, lexer)

l.Lexers = add(l.Lexers, lexer)

return lexer
}

// add adds a lexer to a slice of lexers if it doesn't already exist, or if found will replace it.
func add(lexers Lexers, lexer Lexer) Lexers {
for i, val := range lexers {
if val == nil {
continue
}

if val.Config().Name == lexer.Config().Name {
lexers[i] = lexer
return lexers
}
}

return append(lexers, lexer)
}