Add TradingView lexer #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat ( and ) as text in lexer Added test files and small change of lexer Fixed 'err' messages in Chroma output Removed postfix behind numbers Was originally from C# lexer, but not needed for TradingView Improved single comment, punctuation, and operator Simplified text match, improved punctuation and operators Add slash to punctuation Added missing named variables Added proper test data with .expected file Added TradingView lexer
|
Thanks, and I'm glad you're finding Chroma easy to navigate 👍 |
|
Thanks for accepting the pull request! 🙂 |
mrsdizzie
pushed a commit
to mrsdizzie/chroma
that referenced
this pull request
Jul 15, 2020
Add TradingView lexer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes to add a lexer to Chroma for TradingView (https://www.tradingview.com). TradingView is an online website where people can code scripts that analyse or trade financial markets. Here's an overview of their language reference. They claim themselves that 7 million people use their website/tools (although not everyone will be writing scripts).
I've verified the syntax highlight made by this lexer against their online editor, and it matches. I've also cleaned up the regex as much as possible so that performance remains optimal. There's also a test (expected and actual) added.
Let me know if I missed something or if you have comments, suggestions, or questions. I'd happily look into them.
(By the way, just want to say that Chroma is great tool. I'm still starting out with Go but made good progress in little time because of the nice way that Chroma is set up. 🙂 )