Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a chroma class wrapper when in "table" mode #62

Closed
bep opened this issue Oct 13, 2017 · 1 comment · Fixed by #63
Closed

Add a chroma class wrapper when in "table" mode #62

bep opened this issue Oct 13, 2017 · 1 comment · Fixed by #63

Comments

@bep
Copy link
Contributor

bep commented Oct 13, 2017 •
edited
Loading

This does not matter too much to me, and I didn't notice this in my initial testing because html.Standalone() adds the chroma class to body.

But in standalone mode, you'll get <table class="lntable"> and the CSS selectors will not match.
@bep bep changed the title Add a chroma class "wrapper" when in "table" mode Add a chroma class when in "table" mode Oct 13, 2017
@bep bep changed the title Add a chroma class when in "table" mode Add a chroma class wrapper when in "table" mode Oct 13, 2017
@bep
Copy link
Contributor Author

bep commented Oct 13, 2017

I have a couple of other subtle CSS fixes that gets visible when you combine this with other stylesheets (re. Hugo); this could be fixed by the user, but Chroma should help. I will create a PR for these later today/evening.

@bep bep mentioned this issue Oct 13, 2017
Merged
alecthomas pushed a commit that referenced this issue Oct 14, 2017
@bep @alecthomas
Add a chroma class wrapper when in "table mode" (#63)
02c4adc 
This commits adds a div wrapper when linenumbers are formatted in table, to get the correct CSS matchers.

This commit also fixes some CSS table issues when tables are put into a larger context with other stylesheets:

* No borders.
* Overflow to fit in potentially narrower containers.

Fixes #62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a chroma class wrapper when in "table mode"
1 participant
@bep