-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vite-tsconfig-paths cannot import a basic TSconfig extends in sub-folder #150
Comments
Note also that without |
@matthew-dean Did you find a fix? |
In the case of @matthew-dean's reproduction, the fix is to set Example
|
Fixed in v5.1.4 |
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
This comment was marked as off-topic.
This comment was marked as off-topic.
Hi @mamunonweb, that's not related to this issue. Try reproducing your issue in the test suite by tweaking the paths-outside-root test fixture until it fails. You can run the test with this command:
|
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.1.3 | 5.1.4 | ## [v5.1.4](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.4) - **fix:** correctly infer the `paths` root dir ([`eea1c17`](aleclarson/vite-tsconfig-paths@eea1c17)) ([#150](aleclarson/vite-tsconfig-paths#150))
I've reduced the test case to this: https://stackblitz.com/edit/vitest-dev-vitest-oip9io?initialPath=__vitest__/
You can see that this Vite plugin fails entirely to resolve paths using TSConfig settings.
It's important to note that:
tsconfig.json
file, but vite-tsconfig-paths does not account for that, and incorrectly merges path options.The text was updated successfully, but these errors were encountered: