add mutex to TimeStart and TimeEnd functions

CHANGELOG.md

@@ -1,3 +1,5 @@
+* 0.6.1
+    * Bugfix: Add mutex for time monitoring map 
 * 0.6.0
     * Feature: Add prometheus reporter
     * Bugfix: Fix race condition when notifying waiting clients about response 

cmd/mort/mort.go

@@ -30,7 +30,7 @@ import (
 
 const (
 	// Version of mort
-	Version = "0.6.0"
+	Version = "0.6.1"
 	// BANNER just fancy command line banner
 	BANNER = `
   /\/\   ___  _ __| |_
@@ -130,7 +130,7 @@ func configureMonitoring(mortConfig *config.Config) {
 
 		p.RegisterHistogramVec("response_time", prometheus.NewHistogramVec(prometheus.HistogramOpts{
 			Name:    "mort_response_time",
-			Help:    "mort reponse times",
+			Help:    "mort response times",
 			Buckets: []float64{10, 50, 100, 200, 300, 400, 500, 1000, 2000, 3000, 4000, 5000, 6000, 10000, 30000, 60000},
 		},
 			[]string{"method"},

pkg/config/config.go

@@ -39,6 +39,7 @@ func GetInstance() *Config {
 	return instance
 }
 
+// RegisterTransformKind register new transformation in config validator
 func RegisterTransformKind(kind string) {
 	for _, k := range transformKinds {
 		if k == kind {

pkg/monitoring/prometheus.go

@@ -4,6 +4,7 @@ import (
 	"github.com/prometheus/client_golang/prometheus"
 	"strings"
 	"time"
+	"sync"
 )
 
 // PrometheusReporter is a reporter that allow you to "send" metrics to
@@ -18,6 +19,7 @@ type PrometheusReporter struct {
 	histograms    map[string]prometheus.Histogram
 	histogramsVec map[string]*prometheus.HistogramVec
 	timers        map[string]time.Time
+	timersLock   sync.RWMutex
 }
 
 // NewPrometheusReporter create instance of reporter that allow you to report stats to prometheus
@@ -99,14 +101,17 @@ func (p *PrometheusReporter) Histogram(metric string, val float64) {
 // Result will be histogram of time
 // metric schema: metric_name;label:value,label1:value2
 func (p *PrometheusReporter) TimeStart(metric string) {
+	p.timersLock.Lock()
 	p.timers[metric] = time.Now()
+	p.timersLock.Unlock()
 }
 
 // TimeEnd - end time measure for given metric
 func (p *PrometheusReporter) TimeEnd(metric string) {
+	p.timersLock.RLock()
 	delta := time.Since(p.timers[metric])
+	p.timersLock.RUnlock()
 	p.Histogram(metric, float64(delta.Nanoseconds()/1000))
-	delete(p.timers, metric)
 }
 
 // RegisterCounter register counter in prometheus default registry

pkg/object/uri.go

@@ -17,7 +17,7 @@ var bufPool = sync.Pool{
 	},
 }
 
-// ParserFnc is a function that create object from request url
+// ParseFnc is a function that create object from request url
 type ParseFnc func(url *url.URL, bucketConfig config.Bucket, obj *FileObject) (string, error)
 
 // parser list of available decoder function