Conversation
b17620f to
11e83e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (and this crate) are made specifically for being used in uv cache-key globbing but may be useful for general public as well in cases where globwalk doesn't quite cover it.
Initial version that should pretty much fully work (as much as I've tested).
It also has different edge cases than walkdir (e.g. avoiding duplicates may require canonicalization, because of allowing relative/abs paths), etc.
What it does - given a base path and a list of patterns, constructs tries and globsets at its vertices and tries to walk it in an efficient way without walking the same folder twice (as opposed to "walk everything, then filter"). Relative and absolute paths are also supported. AFAIK, there's no current easy solutions to this.
Why not globwalk? (currently used in uv)
Notes:
@BurntSushi this is based on two of yours crates (thanks for that) and some code had to be borrowed from
walkdir- there's a few mentions of that in the code with notes/credits.(Random note: windows tests were a pain, had to cross compile them to wine to debug.)